From: Johan Hovold <johan@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] clk: qcom: gdsc: add collapse-bit helper
Date: Fri, 20 May 2022 14:03:18 +0200 [thread overview]
Message-ID: <YoeDhpCzV2sR7+Y1@hovoldconsulting.com> (raw)
In-Reply-To: <CAA8EJpr3_+iS_ntG0pgfG647Ou4Q60sk+-Roc9GJ-0qM5W710g@mail.gmail.com>
On Fri, May 20, 2022 at 02:50:17PM +0300, Dmitry Baryshkov wrote:
> On Fri, 20 May 2022 at 13:10, Johan Hovold <johan+linaro@kernel.org> wrote:
> >
> > Add a helper for updating the SW_COLLAPSE bit during initialisation and
> > state updates.
> >
>
>
> > Note that the update during initialisation was relying on the
> > SW_COLLAPSE bit not having been set earlier rather than passing in zero
> > explicitly to clear the collapse vote.
>
> I think this part deserves a separate commit with proper Fixes: tag.
No, it's not a bug. The value passed in is explicitly set a bit higher
up in the same function so that the SW_COLLAPSE bit is (currently) never
set.
It mostly just looks weird and probably wasn't intentional.
> > @@ -425,8 +437,7 @@ static int gdsc_init(struct gdsc *sc)
> > * If a Votable GDSC is ON, make sure we have a Vote.
> > */
> > if (sc->flags & VOTABLE) {
> > - ret = regmap_update_bits(sc->regmap, sc->gdscr,
> > - SW_COLLAPSE_MASK, val);
> > + ret = gdsc_update_collapse_bit(sc, false);
> > if (ret)
> > return ret;
> > }
Johan
next prev parent reply other threads:[~2022-05-20 12:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 10:09 [PATCH 0/3] clk: qcom: gdsc: add support for collapse-vote registers Johan Hovold
2022-05-20 10:09 ` [PATCH 1/3] clk: qcom: gdsc: add collapse-bit helper Johan Hovold
2022-05-20 11:50 ` Dmitry Baryshkov
2022-05-20 12:03 ` Johan Hovold [this message]
2022-05-20 10:09 ` [PATCH 2/3] clk: qcom: gdsc: add support for collapse-vote registers Johan Hovold
2022-05-21 3:52 ` Stephen Boyd
2022-05-23 12:04 ` Johan Hovold
2022-05-26 18:32 ` Stephen Boyd
2022-06-09 11:50 ` Johan Hovold
2022-05-20 10:09 ` [PATCH 3/3] clk: qcom: gcc-sc8280xp: use collapse-voting for PCIe GDSCs Johan Hovold
2022-05-21 3:51 ` [PATCH 0/3] clk: qcom: gdsc: add support for collapse-vote registers Stephen Boyd
2022-05-23 9:32 ` Johan Hovold
2022-05-26 18:33 ` Stephen Boyd
2022-06-23 11:44 ` Johan Hovold
2022-06-27 20:02 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoeDhpCzV2sR7+Y1@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).