From: Matthew Wilcox <willy@infradead.org>
To: Chen Wandun <chenwandun@huawei.com>
Cc: hughd@google.com, akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, david@redhat.com,
wangkefeng.wang@huawei.com
Subject: Re: [PATCH v2 1/3] mm/shmem: check return value of shmem_init_inodecache
Date: Sun, 5 Jun 2022 12:49:28 +0100 [thread overview]
Message-ID: <YpyYSFjTQQQ/p4bM@casper.infradead.org> (raw)
In-Reply-To: <20220605035557.3957759-2-chenwandun@huawei.com>
On Sun, Jun 05, 2022 at 11:55:55AM +0800, Chen Wandun wrote:
> It will result in null pointer access if shmem_init_inodecache fail,
> so check return value of shmem_init_inodecache
You ignored my suggestion from v1. Here, let me write it out for you.
+static int shmem_init_inodecache(void)
{
shmem_inode_cachep = kmem_cache_create("shmem_inode_cache",
sizeof(struct shmem_inode_info),
0, SLAB_PANIC|SLAB_ACCOUNT, shmem_init_inode);
+ if (!shmem_inode_cachep)
+ return -ENOMEM;
+ return 0;
}
...
+ error = shmem_init_inodecache();
+ if (error)
+ goto out2;
next prev parent reply other threads:[~2022-06-05 11:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-05 3:55 [PATCH v2 0/3] a few cleanup and bugfixes about shmem Chen Wandun
2022-06-05 3:55 ` [PATCH v2 1/3] mm/shmem: check return value of shmem_init_inodecache Chen Wandun
2022-06-05 11:49 ` Matthew Wilcox [this message]
2022-06-06 1:34 ` Chen Wandun
2022-06-06 2:08 ` Matthew Wilcox
2022-06-06 2:58 ` Chen Wandun
2022-06-05 3:55 ` [PATCH v2 2/3] mm/shmem: return error code directly for invalid addr Chen Wandun
2022-06-05 3:55 ` [PATCH v2 3/3] mm/shmem: rework calculation of inflated_addr in shmem_get_unmapped_area Chen Wandun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpyYSFjTQQQ/p4bM@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=chenwandun@huawei.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).