From: Sam Ravnborg <sam@ravnborg.org>
To: Stephen Kitt <steve@sk2.org>
Cc: Antonino Daplas <adaplas@gmail.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Helge Deller <deller@gmx.de>, Paul Mackerras <paulus@samba.org>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/7] fbdev: aty128fb: Use backlight helper
Date: Fri, 10 Jun 2022 22:29:12 +0200 [thread overview]
Message-ID: <YqOpmKlLl909F/Ib@ravnborg.org> (raw)
In-Reply-To: <20220607192335.1137249-2-steve@sk2.org>
Hi Stepehen,
On Tue, Jun 07, 2022 at 09:23:29PM +0200, Stephen Kitt wrote:
> Instead of retrieving the backlight brightness in struct
> backlight_properties manually, and then checking whether the backlight
> should be on at all, use backlight_get_brightness() which does all
> this and insulates this from future changes.
>
> Signed-off-by: Stephen Kitt <steve@sk2.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Helge Deller <deller@gmx.de>
> Cc: linux-fbdev@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
This and the other 6 patches in this series are all:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
I did not receive the cover letter, which is why I reply to this mail.
Sam
next prev parent reply other threads:[~2022-06-10 20:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 19:23 [PATCH 0/7] fbdev: Use backlight helpers Stephen Kitt
2022-06-07 19:23 ` [PATCH 1/7] fbdev: aty128fb: Use backlight helper Stephen Kitt
2022-06-10 20:29 ` Sam Ravnborg [this message]
2022-06-07 19:23 ` [PATCH 2/7] fbdev: atyfb: " Stephen Kitt
2022-06-07 19:23 ` [PATCH 3/7] fbdev: radeon: " Stephen Kitt
2022-06-07 19:23 ` [PATCH 4/7] fbdev: mx3fb: " Stephen Kitt
2022-06-07 19:23 ` [PATCH 5/7] fbdev: nvidia: " Stephen Kitt
2022-06-07 19:23 ` [PATCH 6/7] fbdev: omapfb: panel-dsi-cm: " Stephen Kitt
2022-06-07 19:23 ` [PATCH 7/7] fbdev: riva: " Stephen Kitt
2022-06-08 14:40 ` [PATCH 0/7] fbdev: Use backlight helpers Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqOpmKlLl909F/Ib@ravnborg.org \
--to=sam@ravnborg.org \
--cc=adaplas@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=steve@sk2.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).