From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E75EC433EF for ; Sun, 12 Jun 2022 22:19:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237103AbiFLWRp (ORCPT ); Sun, 12 Jun 2022 18:17:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237283AbiFLWQp (ORCPT ); Sun, 12 Jun 2022 18:16:45 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 615A0522D8 for ; Sun, 12 Jun 2022 15:16:43 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id j20so4404330ljg.8 for ; Sun, 12 Jun 2022 15:16:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=sunDVi/ticftrmGFGD0ymqsOh72W45vWbx1D2LbSq4s=; b=asLN9hjKyM34whmshERovu7s3c3BhM+F7MTfEN9BXMNwm1aDR0HpuRBlKYUTUT4uS9 egeaexlIXxY7Pgglt35XChh8Q/5MDS6Z3frnxjAHtGBhFJGIF+ZMgGspG/NxBw3mc2HO rEd0Jafy0ABL8PJYkhUXHSy+IpekdZIb+DwejUuxiW6DfKyvC/iJUT/5kKtZImgYn3G1 uCJ2nhmt8p6buatbjH+gbDaDx2h847+C+G7mivFkULwRwatyRMNMMRp0zzhKUhTzIVLc IDZVCiOxGzvDqpNEkmtHc+HcO+F2nK4RcN6XCeAQP4rWHCEvVi8bAprDmngpmZ0M4dmo RB6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=sunDVi/ticftrmGFGD0ymqsOh72W45vWbx1D2LbSq4s=; b=gCjWWTgpd+mopDO613mi23IjlM33hgTyR8UzM191FQRvUM7QEyMBzxVtfSL006S2OV QEj7+oQOe3tQmb2sPXXMHhnAah8xGqadVxG+b1JAeE7+CramJQr0Vqd5w36N8WzfJx54 FOhqp1B978F+3ab6oMOJe9Xo3AjyS2iX3Ew6DwLLIwc+zeJ3FkUlFl2o7MZFjWEEBkb3 YIsC40ivQZGJkojGWce7SCaubm/cqwobJ9Lo0JSMz9EpSjEfym7Xt+0hg3l594nurbXT VQBefAufW3a5IEDApaVrduGp0OFkLtg8/C+rzzaLHoxEMI/1RdEYgiYEBfLDMm/EbawR Mrww== X-Gm-Message-State: AOAM533TJzLe/G2nSanG+0BTG6iOPM0/vrmnn6GcKAjWvSPpCRd72vWp OaCAMN8DLscBed1povFbFPntHQ== X-Google-Smtp-Source: ABdhPJyiW858OSRKNb3DyVbWavm4PLqO5MZ0BncdZxJ3DWEye/I3ZGfWCBKVqmVWhgfOznBLaDYK2w== X-Received: by 2002:a2e:6a0d:0:b0:255:7341:145 with SMTP id f13-20020a2e6a0d000000b0025573410145mr28908880ljc.360.1655072201580; Sun, 12 Jun 2022 15:16:41 -0700 (PDT) Received: from localhost (h-85-24-188-65.A463.priv.bahnhof.se. [85.24.188.65]) by smtp.gmail.com with ESMTPSA id z10-20020a0565120c0a00b00477cc59e376sm741820lfu.161.2022.06.12.15.16.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jun 2022 15:16:41 -0700 (PDT) Date: Mon, 13 Jun 2022 00:16:40 +0200 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Wolfram Sang Cc: linux-renesas-soc@vger.kernel.org, "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Rob Herring , Krzysztof Kozlowski , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] dt-bindings: thermal: rcar-gen3-thermal: use positive logic Message-ID: References: <20220610201701.7946-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220610201701.7946-1-wsa+renesas@sang-engineering.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram, Thanks for your patch. On 2022-06-10 22:17:00 +0200, Wolfram Sang wrote: > When handling the V3U/r8a779a0 exception, avoid using 'not:' because > then its subschemas are far away in the 'else:' branch. Keep them > together using positive logic. > > Signed-off-by: Wolfram Sang Reviewed-by: Niklas Söderlund > --- > > Changes since v2: > * new patch > > Tested with: > make dtbs_check DT_SCHEMA_FILES=thermal/rcar-gen3-thermal.yaml > > .../bindings/thermal/rcar-gen3-thermal.yaml | 21 +++++++++---------- > 1 file changed, 10 insertions(+), 11 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml > index 1368d90da0e8..72dc7eb27f8d 100644 > --- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml > +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml > @@ -57,31 +57,30 @@ required: > - "#thermal-sensor-cells" > > if: > - not: > - properties: > - compatible: > - contains: > - enum: > - - renesas,r8a779a0-thermal > + properties: > + compatible: > + contains: > + enum: > + - renesas,r8a779a0-thermal > then: > properties: > reg: > - minItems: 2 > items: > + - description: TSC0 registers > - description: TSC1 registers > - description: TSC2 registers > - description: TSC3 registers > - required: > - - interrupts > + - description: TSC4 registers > else: > properties: > reg: > + minItems: 2 > items: > - - description: TSC0 registers > - description: TSC1 registers > - description: TSC2 registers > - description: TSC3 registers > - - description: TSC4 registers > + required: > + - interrupts > > additionalProperties: false > > -- > 2.35.1 > -- Kind Regards, Niklas Söderlund