From: Cristian Marussi <cristian.marussi@arm.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, sudeep.holla@arm.com,
james.quinlan@broadcom.com, Jonathan.Cameron@huawei.com,
etienne.carriere@linaro.org, vincent.guittot@linaro.org,
souvik.chakravarty@arm.com
Subject: Re: [PATCH 11/22] firmware: arm_scmi: Add SCMIv3.1 extended names protocols support
Date: Wed, 15 Jun 2022 09:17:52 +0100 [thread overview]
Message-ID: <YqmVsMGgxKuIT5rx@e120937-lin> (raw)
In-Reply-To: <6f865d7f-fde8-d923-3c7e-d12bfbc370a6@gmail.com>
On Wed, Jun 15, 2022 at 05:45:11AM +0200, Florian Fainelli wrote:
>
>
> On 3/30/2022 5:05 PM, Cristian Marussi wrote:
> > Using the common protocol helper implementation add support for all new
> > SCMIv3.1 extended names commands related to all protocols with the
> > exception of SENSOR_AXIS_GET_NAME.
> >
> > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
>
> This causes the following splat on a platform where regulators fail to
> initialize:
>
Hi Florian,
thanks for the report.
It seems a memory error while allocating so it was not meant to be
solved by the fixes, anyway, I've never seen this splat in my testing
and at first sight I cannot see anything wrong in the devm_k* calls
inside scmi_voltage_protocol_init...is there any particular config in
your setup ?
Moreover, the WARNING line 5402 seems to match v5.19-rc1 and it has
slightly changed with -rc-1, so I'll try rebasing on that at first and
see if I can reproduce the issue locally.
Thanks,
Cristian
> [ 0.603737] ------------[ cut here ]------------
> [ 0.603752] WARNING: CPU: 1 PID: 1 at mm/page_alloc.c:5402
> __alloc_pages+0x6c/0x184
> [ 0.603797] Modules linked in:
> [ 0.603809] CPU: 1 PID: 1 Comm: swapper/0 Not tainted
> 5.19.0-rc1-g44dbdf3bb3f4 #42
> [ 0.603818] Hardware name: BCX972160SV (DT)
> [ 0.603825] pstate: 20000005 (nzCv daif -PAN -UAO -TCO -DIT -SSBS
> BTYPE=--)
> [ 0.603834] pc : __alloc_pages+0x6c/0x184
> [ 0.603841] lr : kmalloc_order+0x40/0x88
> [ 0.603851] sp : ffffffc00a40b850
> [ 0.603856] x29: ffffffc00a40b850 x28: 0000000000000000 x27:
> ffffffc008d60404
> [ 0.603867] x26: ffffff80c1e3e1a8 x25: ffffffc00877bd78 x24:
> 0000000000000058
> [ 0.603878] x23: ffffffc0081921a8 x22: ffffffc008cb04b0 x21:
> 0000000000000000
> [ 0.603889] x20: 000000000000000b x19: 000000000000000b x18:
> 0000000000000000
> [ 0.603900] x17: 0000000000000001 x16: 0000000100000000 x15:
> 000000000000000a
> [ 0.603911] x14: 0000000000000000 x13: ffffff80c1e3c20a x12:
> ffffffffffffffff
> [ 0.603922] x11: 0000000000000020 x10: 0000000000000880 x9 :
> ffffffc008159dac
> [ 0.603932] x8 : ffffff80c02708e0 x7 : 0000000000000004 x6 :
> 000000000041a880
> [ 0.603943] x5 : 0000000000000001 x4 : ffffff8000000000 x3 :
> 0000000000000000
> [ 0.603954] x2 : 0000000000000000 x1 : 0000000000000001 x0 :
> ffffffc00a32d3f2
> [ 0.603965] Call trace:
> [ 0.603970] __alloc_pages+0x6c/0x184
> [ 0.603977] kmalloc_order+0x40/0x88
> [ 0.603984] kmalloc_order_trace+0x30/0xd0
> [ 0.603992] __kmalloc_track_caller+0x64/0x19c
> [ 0.603999] devm_kmalloc+0x5c/0xe0
> [ 0.604009] scmi_voltage_protocol_init+0x14c/0x2f4
> [ 0.604020] scmi_get_protocol_instance+0x128/0x1f4
> [ 0.604030] scmi_devm_protocol_get+0x64/0xc8
> [ 0.604037] scmi_regulator_probe+0x5c/0x42c
> [ 0.604049] scmi_dev_probe+0x28/0x38
> [ 0.604056] really_probe+0x1b8/0x380
> [ 0.604065] __driver_probe_device+0x14c/0x164
> [ 0.604073] driver_probe_device+0x48/0xe0
> [ 0.604080] __driver_attach+0x160/0x170
> [ 0.604087] bus_for_each_dev+0x78/0xb8
> [ 0.604095] driver_attach+0x28/0x30
> [ 0.604101] bus_add_driver+0xf4/0x208
> [ 0.604108] driver_register+0xb4/0xf0
> [ 0.604116] scmi_driver_register+0x5c/0xa4
> [ 0.604123] scmi_drv_init+0x28/0x30
> [ 0.604132] do_one_initcall+0x80/0x1a4
> [ 0.604141] kernel_init_freeable+0x220/0x23c
> [ 0.604149] kernel_init+0x28/0x128
> [ 0.604158] ret_from_fork+0x10/0x20
> [ 0.604166] ---[ end trace 0000000000000000 ]---
> [ 0.604194] scmi-regulator: probe of scmi_dev.2 failed with error -12
> [ 0.604792] arm-scmi brcm_scmi@0: Failed. SCMI protocol 22 not active.
> --
> Florian
next prev parent reply other threads:[~2022-06-15 8:18 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 15:05 [PATCH 00/22] SCMIv3.1 Miscellaneous changes Cristian Marussi
2022-03-30 15:05 ` [PATCH 01/22] firmware: arm_scmi: Fix sorting of retrieved clock rates Cristian Marussi
2022-03-30 15:05 ` [PATCH 02/22] firmware: arm_scmi: Make protocols init fail on basic errors Cristian Marussi
2022-04-26 15:35 ` Sudeep Holla
2022-04-26 16:25 ` Cristian Marussi
2022-04-28 10:25 ` Sudeep Holla
2022-04-28 12:07 ` Cristian Marussi
2022-03-30 15:05 ` [PATCH 03/22] firmware: arm_scmi: Fix Base list protocols enumeration Cristian Marussi
2022-03-30 15:05 ` [PATCH 04/22] firmware: arm_scmi: Validate BASE_DISCOVER_LIST_PROTOCOLS reply Cristian Marussi
2022-04-28 10:07 ` Sudeep Holla
2022-04-28 13:45 ` Cristian Marussi
2022-04-28 13:55 ` Sudeep Holla
2022-04-28 14:03 ` Cristian Marussi
2022-03-30 15:05 ` [PATCH 05/22] firmware: arm_scmi: Dynamically allocate protocols array Cristian Marussi
2022-04-28 10:27 ` Sudeep Holla
2022-03-30 15:05 ` [PATCH 06/22] firmware: arm_scmi: Make name_get operations return a const Cristian Marussi
2022-03-30 15:05 ` [PATCH 07/22] firmware: arm_scmi: Check CLOCK_RATE_SET_COMPLETE async reply Cristian Marussi
2022-03-30 15:05 ` [PATCH 08/22] firmware: arm_scmi: Remove unneeded NULL termination of clk name Cristian Marussi
2022-03-30 15:05 ` [PATCH 09/22] firmware: arm_scmi: Split protocol specific definitions in a dedicated header Cristian Marussi
2022-03-30 15:05 ` [PATCH 10/22] firmware: arm_scmi: Introduce a common SCMIv3.1 .extended_name_get helper Cristian Marussi
2022-03-30 15:05 ` [PATCH 11/22] firmware: arm_scmi: Add SCMIv3.1 extended names protocols support Cristian Marussi
2022-06-15 3:45 ` Florian Fainelli
2022-06-15 8:17 ` Cristian Marussi [this message]
2022-06-15 9:40 ` Cristian Marussi
2022-06-15 16:10 ` Florian Fainelli
2022-06-15 16:29 ` Cristian Marussi
2022-06-15 17:19 ` Florian Fainelli
2022-06-15 17:32 ` Cristian Marussi
2022-06-15 22:58 ` Florian Fainelli
2022-03-30 15:05 ` [PATCH 12/22] firmware: arm_scmi: Parse clock_enable_latency conditionally Cristian Marussi
2022-03-30 15:05 ` [PATCH 13/22] firmware: arm_scmi: Add iterators for multi-part commands Cristian Marussi
2022-03-30 15:05 ` [PATCH 14/22] firmware: arm_scmi: Use common iterators in Sensor protocol Cristian Marussi
2022-03-30 15:05 ` [PATCH 15/22] firmware: arm_scmi: Add SCMIv3.1 SENSOR_AXIS_NAME_GET support Cristian Marussi
2022-06-02 14:25 ` Peter Hilber
2022-06-06 8:18 ` Cristian Marussi
2022-06-08 8:40 ` Peter Hilber
2022-06-08 8:49 ` Cristian Marussi
2022-03-30 15:05 ` [PATCH 16/22] firmware: arm_scmi: Use common iterators in Clock protocol Cristian Marussi
2022-03-30 15:05 ` [PATCH 17/22] firmware: arm_scmi: Use common iterators in Voltage protocol Cristian Marussi
2022-03-30 15:05 ` [PATCH 18/22] firmware: arm_scmi: Use common iterators in Perf protocol Cristian Marussi
2022-03-30 15:05 ` [PATCH 19/22] firmware: arm_scmi: Add SCMIv3.1 Clock notifications Cristian Marussi
2022-03-30 15:05 ` [PATCH 20/22] firmware: arm_scmi: Add SCMIv3.1 VOLTAGE_LEVEL_SET_COMPLETE Cristian Marussi
2022-03-30 15:05 ` [PATCH 21/22] firmware: arm_scmi: Add SCMI v3.1 Perf power-cost in microwatts Cristian Marussi
2022-03-30 16:46 ` Lukasz Luba
2022-03-30 15:05 ` [PATCH 22/22] firmware: arm_scmi: Add SCMIv3.1 PERFORMANCE_LIMITS_SET checks Cristian Marussi
2022-04-28 13:13 ` Sudeep Holla
2022-04-28 13:49 ` Cristian Marussi
2022-04-28 13:52 ` Sudeep Holla
2022-04-28 13:46 ` [PATCH 00/22] SCMIv3.1 Miscellaneous changes Sudeep Holla
2022-05-03 8:03 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqmVsMGgxKuIT5rx@e120937-lin \
--to=cristian.marussi@arm.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=etienne.carriere@linaro.org \
--cc=f.fainelli@gmail.com \
--cc=james.quinlan@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=souvik.chakravarty@arm.com \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).