From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 546E7C433EF for ; Wed, 15 Jun 2022 15:02:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233791AbiFOPCt (ORCPT ); Wed, 15 Jun 2022 11:02:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232744AbiFOPCr (ORCPT ); Wed, 15 Jun 2022 11:02:47 -0400 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB5F16330 for ; Wed, 15 Jun 2022 08:02:45 -0700 (PDT) Received: from pps.filterd (m0134425.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25FBKN1B022318; Wed, 15 Jun 2022 15:02:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pps0720; bh=cHQwY0TBfVoKvBJS9TNkSXSdr+qqw1/qtAJdlPPaAac=; b=XzJ/QBHMxSirnTig0V9hw3PEhTJA0RsjtsM+Qy7nCyG0iHwJZda++zvgovsJtzZVGZXc hh1qNtPATcwrf9ACnkS1UvY31QMEMqUhFLOujr71L0qoEW8J97PrXUQrOwtf0dF2ZXfE HcffMYiuI/GMNXDcF67gBVYzC+UBzc3Y/Rj7vaih67KgLdHCO1iQhXdLgL9TFwyL05ZG 0M6U94mAE38tpDzQX4+ZXbqr9KRYKNjBj9pESK7MPApD3s0O3NhUydwW3bDbWpgz2VAr Vy9L1IUo6QhigrugVD+TwonhBzl3GhgYAS/2/3aALMMJshuGqaVXIek3h8+A/mTOaKzc oQ== Received: from p1lg14879.it.hpe.com (p1lg14879.it.hpe.com [16.230.97.200]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 3gqef8t2w8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Jun 2022 15:02:21 +0000 Received: from p1lg14885.dc01.its.hpecorp.net (unknown [10.119.18.236]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by p1lg14879.it.hpe.com (Postfix) with ESMTPS id EE0BC1478F; Wed, 15 Jun 2022 15:02:19 +0000 (UTC) Received: from swahl-home.5wahls.com (unknown [16.231.227.36]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) by p1lg14885.dc01.its.hpecorp.net (Postfix) with ESMTPS id A149283870C; Wed, 15 Jun 2022 15:02:16 +0000 (UTC) Date: Wed, 15 Jun 2022 10:02:14 -0500 From: Steve Wahl To: Baolu Lu Cc: Steve Wahl , Jerry Snitselaar , Joerg Roedel , Kyung Min Park , David Woodhouse , Will Deacon , iommu , Mike Travis , Dimitri Sivanich , Russ Anderson , Linux List Kernel Mailing Subject: Re: [PATCH v2] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting Message-ID: References: <20220613205734.3x7i46bnsofzerr4@cantor> <673eb011-94f4-46b0-f1b4-24a02a269f4e@linux.intel.com> <9c943703-0c2f-b654-a28b-f594bf90bec9@linux.intel.com> <616dc81c-dfc6-d6c6-1eab-de0e9ba4411f@linux.intel.com> <20220614190145.dkdwjnqnd7lv6y4n@cantor> <9d6177ac-802f-eb11-4307-b0e49d8126b5@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9d6177ac-802f-eb11-4307-b0e49d8126b5@linux.intel.com> X-Proofpoint-GUID: bB2PVBc_8EbJ9irlOMT9z_iBCh4EmkNy X-Proofpoint-ORIG-GUID: bB2PVBc_8EbJ9irlOMT9z_iBCh4EmkNy X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-06-15_14,2022-06-15_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 malwarescore=0 adultscore=0 suspectscore=0 clxscore=1015 impostorscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206150058 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 15, 2022 at 09:38:35AM +0800, Baolu Lu wrote: > On 2022/6/15 05:12, Steve Wahl wrote: > > On Tue, Jun 14, 2022 at 12:01:45PM -0700, Jerry Snitselaar wrote: > > > On Tue, Jun 14, 2022 at 11:45:35AM -0500, Steve Wahl wrote: > > > > On Tue, Jun 14, 2022 at 10:21:29AM +0800, Baolu Lu wrote: > > > > > On 2022/6/14 09:54, Jerry Snitselaar wrote: > > > > > > On Mon, Jun 13, 2022 at 6:51 PM Baolu Lu wrote: > > > > > > > > > > > > > > On 2022/6/14 09:44, Jerry Snitselaar wrote: > > > > > > > > On Mon, Jun 13, 2022 at 6:36 PM Baolu Lu wrote: > > > > > > > > > On 2022/6/14 04:57, Jerry Snitselaar wrote: > > > > > > > > > > On Thu, May 12, 2022 at 10:13:09AM -0500, Steve Wahl wrote: > > > > > > > > > > > To support up to 64 sockets with 10 DMAR units each (640), make the > > > > > > > > > > > value of DMAR_UNITS_SUPPORTED adjustable by a config variable, > > > > > > > > > > > CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is > > > > > > > > > > > set. > > > > > > > > > > > > > > > > > > > > > > If the available hardware exceeds DMAR_UNITS_SUPPORTED (previously set > > > > > > > > > > > to MAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to > > > > > > > > > > > allocate seq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ > > > > > > > > > > > remapping doesn't support X2APIC mode x2apic disabled"; and the system > > > > > > > > > > > fails to boot properly. > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Steve Wahl > > > > > > > > > > > --- > > > > > > > > > > > > > > > > > > > > > > Note that we could not find a reason for connecting > > > > > > > > > > > DMAR_UNITS_SUPPORTED to MAX_IO_APICS as was done previously. Perhaps > > > > > > > > > > > it seemed like the two would continue to match on earlier processors. > > > > > > > > > > > There doesn't appear to be kernel code that assumes that the value of > > > > > > > > > > > one is related to the other. > > > > > > > > > > > > > > > > > > > > > > v2: Make this value a config option, rather than a fixed constant. The default > > > > > > > > > > > values should match previous configuration except in the MAXSMP case. Keeping the > > > > > > > > > > > value at a power of two was requested by Kevin Tian. > > > > > > > > > > > > > > > > > > > > > > drivers/iommu/intel/Kconfig | 6 ++++++ > > > > > > > > > > > include/linux/dmar.h | 6 +----- > > > > > > > > > > > 2 files changed, 7 insertions(+), 5 deletions(-) > > > > > > > > > > > > > > > > > > > > > > diff --git a/drivers/iommu/intel/Kconfig b/drivers/iommu/intel/Kconfig > > > > > > > > > > > index 247d0f2d5fdf..fdbda77ac21e 100644 > > > > > > > > > > > --- a/drivers/iommu/intel/Kconfig > > > > > > > > > > > +++ b/drivers/iommu/intel/Kconfig > > > > > > > > > > > @@ -9,6 +9,12 @@ config DMAR_PERF > > > > > > > > > > > config DMAR_DEBUG > > > > > > > > > > > bool > > > > > > > > > > > > > > > > > > > > > > +config DMAR_UNITS_SUPPORTED > > > > > > > > > > > + int "Number of DMA Remapping Units supported" > > > > > > > > > > Also, should there be a "depends on (X86 || IA64)" here? > > > > > > > > > Do you have any compilation errors or warnings? > > > > > > > > > > > > > > > > > > Best regards, > > > > > > > > > baolu > > > > > > > > > > > > > > > > > I think it is probably harmless since it doesn't get used elsewhere, > > > > > > > > but our tooling was complaining to me because DMAR_UNITS_SUPPORTED was > > > > > > > > being autogenerated into the configs for the non-x86 architectures we > > > > > > > > build (aarch64, s390x, ppcle64). > > > > > > > > We have files corresponding to the config options that it looks at, > > > > > > > > and I had one for x86 and not the others so it noticed the > > > > > > > > discrepancy. > > > > > > > > > > > > > > So with "depends on (X86 || IA64)", that tool doesn't complain anymore, > > > > > > > right? > > > > > > > > > > > > > > Best regards, > > > > > > > baolu > > > > > > > > > > > > > > > > > > > Yes, with the depends it no longer happens. > > > > > > > > > > The dmar code only exists on X86 and IA64 arch's. Adding this depending > > > > > makes sense to me. I will add it if no objections. > > > > > > > > I think that works after Baolu's patchset that makes intel-iommu.h > > > > private. I'm pretty sure it wouldn't have worked before that. > > > > > > > > No objections. > > > > > > > > > > Yes, I think applying it with the depends prior to Baolu's change would > > > still run into the issue from the KTR report if someone compiled without > > > INTEL_IOMMU enabled. > > > > > > This was dealing with being able to do something like: > > > > > > make allmodconfig ARCH=arm64 ; grep DMAR_UNITS .config > > > > > > and finding CONFIG_DMAR_UNITS_SUPPORTED=64. > > > > > > Thinking some more though, instead of the depends being on the arch > > > would depending on DMAR_TABLE or INTEL_IOMMU be more appropriate? > > > > At least in my limited exploration, depending on INTEL_IOMMU yields > > compile errors, but depending upon DMAR_TABLE appears to work fine. > > DMAR_TABLE is used beyond INTEL_IOMMU, so depending on DMAR_TABLE seems > better. > > Steve, do you mind posting a v3 with this fixed? I can do that. Expect it shortly. --> Steve -- Steve Wahl, Hewlett Packard Enterprise