linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: AngeloGioacchino Del Regno  <angelogioacchino.delregno@collabora.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	matthias.bgg@gmail.com, johnson.wang@mediatek.com,
	hsin-hsiung.wang@mediatek.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: mfd: mt6397: Add compatibles for MT6331 RTC and keys
Date: Wed, 15 Jun 2022 22:48:31 +0100	[thread overview]
Message-ID: <YqpTrwlXmXMYuDd0@google.com> (raw)
In-Reply-To: <20220520124617.228808-2-angelogioacchino.delregno@collabora.com>

On Fri, 20 May 2022, AngeloGioacchino Del Regno wrote:

> MT6331 is a multifunction device, providing RTC, keys and more: add

No such thing as an MFD.  What does the data-sheet call it?

What "more"?

> the necessary compatibles to start implementing the basics.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  Documentation/devicetree/bindings/mfd/mt6397.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt
> index d59063503b0d..2a9533c47365 100644
> --- a/Documentation/devicetree/bindings/mfd/mt6397.txt
> +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt
> @@ -30,6 +30,7 @@ Optional subnodes:
>  - rtc
>  	Required properties: Should be one of follows
>  		- compatible: "mediatek,mt6323-rtc"
> +		- compatible: "mediatek,mt6331-rtc"
>  		- compatible: "mediatek,mt6358-rtc"
>  		- compatible: "mediatek,mt6397-rtc"
>  	For details, see ../rtc/rtc-mt6397.txt
> @@ -55,6 +56,7 @@ Optional subnodes:
>  - keys
>  	Required properties:
>  		- compatible: "mediatek,mt6397-keys" or "mediatek,mt6323-keys"
> +			      or "mediatek,mt6331-keys"

Please place these in a vertical list.

>  	see ../input/mtk-pmic-keys.txt
>  
>  - power-controller

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

  parent reply	other threads:[~2022-06-15 21:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-20 12:46 [PATCH 0/2] MediaTek Helio X10 MT6795 - MT6331/6332 PMIC MFD integration AngeloGioacchino Del Regno
2022-05-20 12:46 ` [PATCH 1/2] dt-bindings: mfd: mt6397: Add compatibles for MT6331 RTC and keys AngeloGioacchino Del Regno
2022-06-01 11:07   ` Krzysztof Kozlowski
2022-06-15 21:48   ` Lee Jones [this message]
2022-06-16  8:36     ` AngeloGioacchino Del Regno
2022-05-20 12:46 ` [PATCH 2/2] mfd: mt6397: Add basic support for MT6331+MT6332 PMIC AngeloGioacchino Del Regno
2022-06-15 21:52   ` Lee Jones
2022-06-16  8:43     ` AngeloGioacchino Del Regno
2022-06-16 18:40   ` Lee Jones
2022-06-17  7:35     ` AngeloGioacchino Del Regno
2022-06-01 11:03 ` [PATCH 0/2] MediaTek Helio X10 MT6795 - MT6331/6332 PMIC MFD integration AngeloGioacchino Del Regno
2022-06-01 11:07   ` Krzysztof Kozlowski
2022-06-01 11:08     ` AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YqpTrwlXmXMYuDd0@google.com \
    --to=lee.jones@linaro.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hsin-hsiung.wang@mediatek.com \
    --cc=johnson.wang@mediatek.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).