From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, bhupesh.linux@gmail.com,
linux-kernel@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v2 6/6] arm64: dts: qcom: ipq8074: Fix 'max-frequency' value for sdhci node
Date: Thu, 30 Jun 2022 17:54:41 -0500 [thread overview]
Message-ID: <Yr4psYiCCbi15RMe@builder.lan> (raw)
In-Reply-To: <20220514215424.1007718-7-bhupesh.sharma@linaro.org>
On Sat 14 May 16:54 CDT 2022, Bhupesh Sharma wrote:
> Since the Qualcomm sdhci-msm device-tree binding has been converted
> to yaml format, 'make dtbs_check' reports issues with
> 'max-frequency' value for ipq8074 sdhci node:
>
> arch/arm64/boot/dts/qcom/ipq8074-hk01.dtb: mmc@7824900:
> max-frequency:0:0: 384000000 is greater than the maximum of 200000000
>
> Fix the same.
>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> index ab2a1e7955b5..b2d71af9b419 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> @@ -388,7 +388,7 @@ sdhc_1: mmc@7824900 {
> <&gcc GCC_SDCC1_APPS_CLK>,
> <&xo>;
> clock-names = "iface", "core", "xo";
> - max-frequency = <384000000>;
> + max-frequency = <200000000>;
This might match the binding, but someone put 384000000 there for a
reason. Perhaps the binding needs to be updated instead?
Regards,
Bjorn
> mmc-ddr-1_8v;
> mmc-hs200-1_8v;
> mmc-hs400-1_8v;
> --
> 2.35.3
>
next prev parent reply other threads:[~2022-06-30 22:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-14 21:54 [PATCH v2 0/6] arm64: dts: qcom: Fix 'sdhci' nodes for 'make dtbs_check' Bhupesh Sharma
2022-05-14 21:54 ` [PATCH v2 1/6] arm64: dts: qcom: Fix sdhci node names - use 'mmc@' Bhupesh Sharma
2022-05-14 21:54 ` [PATCH v2 2/6] arm64: dts: qcom: sdm630: Fix 'interconnect-names' for sdhci nodes Bhupesh Sharma
2022-05-14 21:54 ` [PATCH v2 3/6] arm64: dts: qcom: Fix node names for sdhci 'opp-table' nodes (across dts files) Bhupesh Sharma
2022-05-14 21:54 ` [PATCH v2 4/6] arm64: dts: qcom: Fix ordering of 'clocks' & 'clock-names' for sdhci nodes Bhupesh Sharma
2022-05-14 21:54 ` [PATCH v2 5/6] arm64: dts: qcom: Fix 'reg-names' " Bhupesh Sharma
2022-07-06 21:48 ` Doug Anderson
2022-05-14 21:54 ` [PATCH v2 6/6] arm64: dts: qcom: ipq8074: Fix 'max-frequency' value for sdhci node Bhupesh Sharma
2022-06-30 22:54 ` Bjorn Andersson [this message]
2022-07-18 8:47 ` Bhupesh Sharma
2022-07-18 12:51 ` Ulf Hansson
2022-07-20 7:40 ` Bhupesh Sharma
2022-07-03 3:55 ` (subset) [PATCH v2 0/6] arm64: dts: qcom: Fix 'sdhci' nodes for 'make dtbs_check' Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yr4psYiCCbi15RMe@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=bhupesh.linux@gmail.com \
--cc=bhupesh.sharma@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).