From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Robert Marko <robimarko@gmail.com>
Cc: agross@kernel.org, jassisinghbrar@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com,
sboyd@kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH v4 4/6] mailbox: qcom-apcs-ipc: add IPQ8074 APSS clock controller support
Date: Thu, 30 Jun 2022 17:59:28 -0500 [thread overview]
Message-ID: <Yr4q0G1AT4YSOIU5@builder.lan> (raw)
In-Reply-To: <20220515204540.477711-4-robimarko@gmail.com>
On Sun 15 May 15:45 CDT 2022, Robert Marko wrote:
> IPQ8074 has the APSS clock controller utilizing the same register space as
> the APCS, so provide access to the APSS utilizing a child device like
> IPQ6018 does as well, but just by utilizing the IPQ8074 specific APSS
> clock driver.
>
> Also, APCS register space in IPQ8074 is 0x6000 so max_register needs to be
> updated to 0x5FFC.
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
> drivers/mailbox/qcom-apcs-ipc-mailbox.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> index 80a54d81412e..b3b9debf5673 100644
> --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> @@ -33,6 +33,10 @@ static const struct qcom_apcs_ipc_data ipq6018_apcs_data = {
> .offset = 8, .clk_name = "qcom,apss-ipq6018-clk"
> };
>
> +static const struct qcom_apcs_ipc_data ipq8074_apcs_data = {
> + .offset = 8, .clk_name = "qcom,apss-ipq8074-clk"
> +};
> +
> static const struct qcom_apcs_ipc_data msm8916_apcs_data = {
> .offset = 8, .clk_name = "qcom-apcs-msm8916-clk"
> };
> @@ -57,7 +61,7 @@ static const struct regmap_config apcs_regmap_config = {
> .reg_bits = 32,
> .reg_stride = 4,
> .val_bits = 32,
> - .max_register = 0x1008,
> + .max_register = 0x5FFC,
Please use lower case hex digits.
And please send the mailbox patches separately, to make it clear for the
maintainers that this can be picked independently of others.
Regards,
Bjorn
> .fast_io = true,
> };
>
> @@ -142,7 +146,7 @@ static int qcom_apcs_ipc_remove(struct platform_device *pdev)
> /* .data is the offset of the ipc register within the global block */
> static const struct of_device_id qcom_apcs_ipc_of_match[] = {
> { .compatible = "qcom,ipq6018-apcs-apps-global", .data = &ipq6018_apcs_data },
> - { .compatible = "qcom,ipq8074-apcs-apps-global", .data = &msm8994_apcs_data },
> + { .compatible = "qcom,ipq8074-apcs-apps-global", .data = &ipq8074_apcs_data },
> { .compatible = "qcom,msm8916-apcs-kpss-global", .data = &msm8916_apcs_data },
> { .compatible = "qcom,msm8939-apcs-kpss-global", .data = &msm8916_apcs_data },
> { .compatible = "qcom,msm8953-apcs-kpss-global", .data = &msm8994_apcs_data },
> --
> 2.36.1
>
next prev parent reply other threads:[~2022-06-30 22:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-15 20:45 [PATCH v4 1/6] clk: qcom: clk-alpha-pll: add support for APSS PLL Robert Marko
2022-05-15 20:45 ` [PATCH v4 2/6] dt-bindings: clock: Add support for IPQ8074 APSS clock controller Robert Marko
2022-05-15 20:45 ` [PATCH v4 3/6] clk: qcom: Add " Robert Marko
2022-05-17 8:14 ` Krzysztof Kozlowski
2022-06-30 23:03 ` Bjorn Andersson
2022-07-04 12:14 ` Robert Marko
2022-05-15 20:45 ` [PATCH v4 4/6] mailbox: qcom-apcs-ipc: add IPQ8074 APSS clock controller support Robert Marko
2022-06-30 22:59 ` Bjorn Andersson [this message]
2022-07-04 19:20 ` Robert Marko
2022-05-15 20:45 ` [PATCH v4 5/6] dt-bindings: mailbox: qcom: set correct #clock-cells Robert Marko
2022-05-15 20:45 ` [PATCH v4 6/6] arm64: dts: ipq8074: add APCS node Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yr4q0G1AT4YSOIU5@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).