From: Christoph Hellwig <hch@infradead.org>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, Yu Kuai <yukuai3@huawei.com>,
Kent Overstreet <kent.overstreet@gmail.com>
Subject: Re: [PATCH 1/3] filemap: Correct the conditions for marking a folio as accessed
Date: Sun, 19 Jun 2022 23:25:31 -0700 [thread overview]
Message-ID: <YrAS2+hjH19LA73A@infradead.org> (raw)
In-Reply-To: <20220619151143.1054746-2-willy@infradead.org>
On Sun, Jun 19, 2022 at 04:11:41PM +0100, Matthew Wilcox (Oracle) wrote:
> +static inline bool pos_same_folio(loff_t pos1, loff_t pos2, struct folio *folio)
>
> +{
> + unsigned int shift = folio_shift(folio);
> +
> + return (pos1 >> shift == pos2 >> shift);
> +}
The calling convention with the folio as the last argument seems a bit
odd to me. But then again so does passing just one folio for checking
if something is in the same folio. But as I can't come up with
something better I'll just deposit these mumblings here insted of
actually complaining.
next prev parent reply other threads:[~2022-06-20 6:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-19 15:11 [PATCH 0/3] Fixes for 5.19b Matthew Wilcox (Oracle)
2022-06-19 15:11 ` [PATCH 1/3] filemap: Correct the conditions for marking a folio as accessed Matthew Wilcox (Oracle)
2022-06-20 6:25 ` Christoph Hellwig [this message]
2022-06-27 9:13 ` [filemap] 91fd26c76b: phoronix-test-suite.fio.SequentialRead.LinuxAIO.Yes.No.4KB.DefaultTestDirectory.mb_s -8.9% regression kernel test robot
2022-06-30 7:29 ` Major btrfs fiemap slowdown on file with many extents once in cache (RCU stalls?) (Was: [PATCH 1/3] filemap: Correct the conditions for marking a folio as accessed) Dominique MARTINET
2022-06-30 14:37 ` Theodore Ts'o
2022-06-30 22:43 ` Dominique MARTINET
2022-07-01 1:55 ` Yu Kuai
2022-07-07 8:42 ` Dominique MARTINET
2022-06-19 15:11 ` [PATCH 2/3] filemap: Handle sibling entries in filemap_get_read_batch() Matthew Wilcox (Oracle)
2022-06-20 10:15 ` Brian Foster
2022-06-19 15:11 ` [PATCH 3/3] mm: Clear page->private when splitting or migrating a page Matthew Wilcox (Oracle)
2022-06-20 6:41 ` Xiubo Li
2022-06-20 23:42 ` Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrAS2+hjH19LA73A@infradead.org \
--to=hch@infradead.org \
--cc=kent.overstreet@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).