From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0312C43334 for ; Wed, 22 Jun 2022 17:01:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377164AbiFVQ7H (ORCPT ); Wed, 22 Jun 2022 12:59:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377003AbiFVQ6a (ORCPT ); Wed, 22 Jun 2022 12:58:30 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE15D39BA2 for ; Wed, 22 Jun 2022 09:58:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7FB13B81D7C for ; Wed, 22 Jun 2022 16:58:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19408C34114; Wed, 22 Jun 2022 16:58:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655917106; bh=jllQadT4DvrMRtLBTBYBV6S5D+eDKQDPfqSBRBCDFNA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L1ISw55PclMBZPb6nTpyfWY6V110GgKc+EMpt7XWMIfYo6Fd0mXHqhTfA77igZvoF fo80oHxO5aQIxqEbznF/FuWRwhnx9lVbq9FKBdWwK8ysvnLzCpN9MxerSlT+3rTakq y9U4y56KYzMhf03XoT98uCh1gMx1kqzyRXo/Hzew45H+M9Yquvth1wTGGoqgnMv6/n vrGehsiVq53cLtIFEmdh3NrHN+kE+H6Vsvc+cKtZ0s9IzonqzWdLft2fKc5330TKmn tS6d/vdRB+wDr9OnnrNmts09Q9/B6o7X3aVP6+zrRyVfQWorsLndR7hrarRjsrbG4G PZB5Vk6PH1rJg== Date: Wed, 22 Jun 2022 09:58:24 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 2/3] f2fs: run GCs synchronously given user requests Message-ID: References: <20220617223106.3517374-1-jaegeuk@kernel.org> <20220617223106.3517374-2-jaegeuk@kernel.org> <27138a10-a6b2-edad-1985-687a95b9039b@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <27138a10-a6b2-edad-1985-687a95b9039b@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/22, Chao Yu wrote: > On 2022/6/20 6:34, Jaegeuk Kim wrote: > > On 06/19, Chao Yu wrote: > > > On 2022/6/18 6:31, Jaegeuk Kim wrote: > > > > When users set GC_URGENT or GC_MID, they expected to do GCs right away. > > > > But, there's a condition to bypass it. Let's indicate we need to do now > > > > in the thread. > > > > > > .should_migrate_blocks is used to force migrating blocks in full > > > section, so what is the condition here? GC should not never select > > > a full section, right? > > > > I think it'll move a full section given .victim_segno is not NULL_SEGNO, > > as __get_victim will give a dirty segment all the time. wdyt? > > However, in gc_thread_fun() victim_segno is NULL_SEGNO all the time. What do you mean? The gc_thread thread sets NULL_SEGNO, which prevents from selecting the full section. But, f2fs_ioc_flush_device will set the segno to move, and f2fs_resize_fs calls do_garbage_collect directly. > > I guess .should_migrate_blocks should only be set to true for > F2FS_IOC_FLUSH_DEVICE/F2FS_IOC_RESIZE_FS case? rather than GC_URGENT or GC_MID > case? See commit 7dede88659df ("f2fs: fix to allow migrating fully valid segment"). > > Thanks, > > > > > > > > > Thanks, > > > > > > > > > > > Signed-off-by: Jaegeuk Kim > > > > --- > > > > fs/f2fs/gc.c | 8 ++++++-- > > > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > > > > index d5fb426e0747..f4aa3c88118b 100644 > > > > --- a/fs/f2fs/gc.c > > > > +++ b/fs/f2fs/gc.c > > > > @@ -37,7 +37,6 @@ static int gc_thread_func(void *data) > > > > unsigned int wait_ms; > > > > struct f2fs_gc_control gc_control = { > > > > .victim_segno = NULL_SEGNO, > > > > - .should_migrate_blocks = false, > > > > .err_gc_skipped = false }; > > > > wait_ms = gc_th->min_sleep_time; > > > > @@ -113,7 +112,10 @@ static int gc_thread_func(void *data) > > > > sbi->gc_mode == GC_URGENT_MID) { > > > > wait_ms = gc_th->urgent_sleep_time; > > > > f2fs_down_write(&sbi->gc_lock); > > > > + gc_control.should_migrate_blocks = true; > > > > goto do_gc; > > > > + } else { > > > > + gc_control.should_migrate_blocks = false; > > > > } > > > > if (foreground) { > > > > @@ -139,7 +141,9 @@ static int gc_thread_func(void *data) > > > > if (!foreground) > > > > stat_inc_bggc_count(sbi->stat_info); > > > > - sync_mode = F2FS_OPTION(sbi).bggc_mode == BGGC_MODE_SYNC; > > > > + sync_mode = F2FS_OPTION(sbi).bggc_mode == BGGC_MODE_SYNC || > > > > + sbi->gc_mode == GC_URGENT_HIGH || > > > > + sbi->gc_mode == GC_URGENT_MID; > > > > /* foreground GC was been triggered via f2fs_balance_fs() */ > > > > if (foreground)