On Fri, Jun 24, 2022 at 05:46:10AM -0700, Joe Perches wrote: > On Fri, 2022-06-24 at 13:11 +0100, Mark Brown wrote: > > On Thu, Jun 23, 2022 at 11:26:10PM +0200, Andy Shevchenko wrote: > > > There is no point to convert the fields you are about to remove. > > > > > So, either don't touch them or make this patch closer to the end of the series. > > It costs us nothing to convert them, this isn't a difficult or hard to > > understand refactoring - the patch is fine the way it is. > Modulo the defects that might be introduced if an overflow occurs. This won't be an issue if the fields are removed which was what Andy was complaining about.