From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C14DCCA480 for ; Fri, 24 Jun 2022 15:25:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232358AbiFXPZI (ORCPT ); Fri, 24 Jun 2022 11:25:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229888AbiFXPZH (ORCPT ); Fri, 24 Jun 2022 11:25:07 -0400 Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [IPv6:2001:4b98:dc4:8::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5553F1AF18; Fri, 24 Jun 2022 08:25:05 -0700 (PDT) Received: (Authenticated sender: paul.kocialkowski@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 597A2200008; Fri, 24 Jun 2022 15:25:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1656084303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1ah9Guq9sVOhK1akYWfj2KUeC+akdxxVJl9dp1GDBNU=; b=POAhcEkE3xV6/f+A6z8Cq1fjuGW0jefiDXthAcHa7mlr1lxHd7f0mTSfEcP1yqWE9fUZ8g W2oppdYGeBLX7UyBih7u7BfR/mm4P+cvlFRMOtf5v8gNi2MM0tjnHrG8E7CyCXxwg1diFf Hjci6jHEEFQuObl6q52c18rzPOuwWu2fBqsx3nmyyilDw/zs1ppvElTis9rvqDrNPnOXal sCRlRdYA+odbYCtFUxfyKuzBcZ33Z2OEo8eALIKmJlxjB5nAR2p+RbMo2VXhbG2SMeS3EA Z51zrbWxIpjc/7ez9hcmEZVhxklWIL4Las4YzCDLfIM+Dp+RYOofLtfq4zMyIg== Date: Fri, 24 Jun 2022 17:25:02 +0200 From: Paul Kocialkowski To: Dan Carpenter Cc: David Airlie , Daniel Vetter , Maxime Ripard , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] drm: logicvc: Fix uninitialized variable in probe Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VYlOOEfoKFRFhdQ2" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --VYlOOEfoKFRFhdQ2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri 24 Jun 22, 16:35, Paul Kocialkowski wrote: > Hi Dan, >=20 > On Tue 14 Jun 22, 15:08, Dan Carpenter wrote: > > The "regmap" is supposed to be initialized to NULL but it's used > > without being initialized. > >=20 > > Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controll= er") > > Signed-off-by: Dan Carpenter >=20 > Nice catch, thanks a lot! >=20 > Acked-by: Paul Kocialkowski Pushed to drm-misc-next, thanks! Paul > Cheers, >=20 > Paul >=20 > > --- > > drivers/gpu/drm/logicvc/logicvc_drm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.c b/drivers/gpu/drm/lo= gicvc/logicvc_drm.c > > index df1805cf0f95..0b983a33f9ff 100644 > > --- a/drivers/gpu/drm/logicvc/logicvc_drm.c > > +++ b/drivers/gpu/drm/logicvc/logicvc_drm.c > > @@ -298,7 +298,7 @@ static int logicvc_drm_probe(struct platform_device= *pdev) > > struct logicvc_drm *logicvc; > > struct device *dev =3D &pdev->dev; > > struct drm_device *drm_dev; > > - struct regmap *regmap; > > + struct regmap *regmap =3D NULL; > > struct resource res; > > void __iomem *base; > > int irq; > > --=20 > > 2.35.1 > >=20 >=20 > --=20 > Paul Kocialkowski, Bootlin > Embedded Linux and kernel engineering > https://bootlin.com --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --VYlOOEfoKFRFhdQ2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmK1104ACgkQ3cLmz3+f v9Hm4Qf9HercPXzmBZcqVWxopvsJO0efqPoHeCi5DfSFDYMjwGt6WH8yKImLlB94 OlKAyLlEgWez+QstD6x1GH6iCB60J6IFc1XN+ITXYgvcOc0CCbC8KpyqhsBTjnRM zOBLz2k7sPZY6ctO+KviLM12W/I61z92CUvqSHxt3hai18LMSreGwjJFSBBLJ+Oo R91iQbd0y5LdV6+0ch/W0zwumkVWGxdUUVg1BeGEGWBftAU6ic+89k+H360v3OWh WBg+mFtw8HCrs2Kd59q5UQb9otGd5hI4oVzcThYt7d1jOUi2boyVE18nYA9+C267 3fggYFkJ6yeCrUrNK5bxqfAtMTgFtg== =LAzp -----END PGP SIGNATURE----- --VYlOOEfoKFRFhdQ2--