From: Brian Masney <bmasney@redhat.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org,
agross@kernel.org, mturquette@baylibre.com,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
ahalaney@redhat.com, echanude@redhat.com
Subject: Re: [PATCH] clk: qcom: sc8280xp: add parent to gcc_ufs_phy_axi_clk for sa8540p
Date: Fri, 24 Jun 2022 12:40:26 -0400 [thread overview]
Message-ID: <YrXo+i3wwl2ERKIj@xps13> (raw)
In-Reply-To: <20220624002055.58BCFC341C0@smtp.kernel.org>
On Thu, Jun 23, 2022 at 05:20:53PM -0700, Stephen Boyd wrote:
> Quoting Brian Masney (2022-06-23 07:28:37)
> > diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c
> > index 4b894442fdf5..4639b50da418 100644
> > --- a/drivers/clk/qcom/gcc-sc8280xp.c
> > +++ b/drivers/clk/qcom/gcc-sc8280xp.c
> > @@ -5696,6 +5709,7 @@ static struct clk_branch gcc_ufs_phy_axi_clk = {
> > .hw.init = &(const struct clk_init_data) {
> > .name = "gcc_ufs_phy_axi_clk",
> > .parent_hws = (const struct clk_hw*[]){
> > + &gcc_ufs_ref_clkref_clk.clkr.hw,
> > &gcc_ufs_phy_axi_clk_src.clkr.hw,
> > },
> > .num_parents = 1,
>
> num_parents needs an update.
Oops!
> But this is a branch, not a mux, so it can't have more than one
> parent.
Would a mux be represented with 'struct clk_rcg2'?
Brian
next prev parent reply other threads:[~2022-06-24 16:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 14:28 [PATCH] clk: qcom: sc8280xp: add parent to gcc_ufs_phy_axi_clk for sa8540p Brian Masney
2022-06-23 15:32 ` Andrew Halaney
2022-06-23 17:13 ` Brian Masney
2022-06-24 0:20 ` Stephen Boyd
2022-06-24 16:40 ` Brian Masney [this message]
2022-06-24 20:16 ` Stephen Boyd
2022-07-16 14:54 ` Bjorn Andersson
2022-07-19 18:49 ` Brian Masney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrXo+i3wwl2ERKIj@xps13 \
--to=bmasney@redhat.com \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=bjorn.andersson@linaro.org \
--cc=echanude@redhat.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).