From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Zhangfei Gao <zhangfei.gao@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Herbert Xu <herbert@gondor.apana.org.au>,
jean-philippe <jean-philippe@linaro.org>,
Wangzhou <wangzhou1@hisilicon.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
acc@openeuler.org, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org, iommu@lists.linux.dev,
Yang Shen <shenyang39@huawei.com>
Subject: Re: [PATCH v2 1/2] uacce: Handle parent driver module removal
Date: Mon, 27 Jun 2022 15:21:56 +0200 [thread overview]
Message-ID: <Yrmu9DcNObmraG72@kroah.com> (raw)
In-Reply-To: <20220624142122.30528-2-zhangfei.gao@linaro.org>
On Fri, Jun 24, 2022 at 10:21:21PM +0800, Zhangfei Gao wrote:
> Change cdev owner to parent driver owner, which blocks rmmod parent
> driver module once fd is opened.
>
> Signed-off-by: Yang Shen <shenyang39@huawei.com>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> ---
> drivers/misc/uacce/uacce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c
> index 281c54003edc..f82f2dd30e76 100644
> --- a/drivers/misc/uacce/uacce.c
> +++ b/drivers/misc/uacce/uacce.c
> @@ -484,7 +484,7 @@ int uacce_register(struct uacce_device *uacce)
> return -ENOMEM;
>
> uacce->cdev->ops = &uacce_fops;
> - uacce->cdev->owner = THIS_MODULE;
> + uacce->cdev->owner = uacce->parent->driver->owner;
What if parent is not set? What if parent does not have a driver set to
it yet? Why would a device's parent module control the lifespan of this
child device's cdev?
This feels wrong and like a layering violation here.
If a parent's module is unloaded, then invalidate the cdev for the
device when you tear it down before the module is unloaded.
Yes, the interaction between the driver model and a cdev is messy, and
always tricky (see the recent ksummit discussion about this again, and
last year's discussion), but that does not mean you should add laying
violations like this to the codebase. Please fix this properly.
thanks,
greg k-h
next prev parent reply other threads:[~2022-06-27 13:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 14:21 [PATCH v2 0/2] fix uacce concurrency issue of uacce_remove Zhangfei Gao
2022-06-24 14:21 ` [PATCH v2 1/2] uacce: Handle parent driver module removal Zhangfei Gao
2022-06-27 13:21 ` Greg Kroah-Hartman [this message]
2022-06-27 14:14 ` Zhangfei Gao
2022-06-24 14:21 ` [PATCH v2 2/2] uacce: Handle parent device removal Zhangfei Gao
2022-06-24 14:37 ` [PATCH v2 0/2] fix uacce concurrency issue of uacce_remove Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yrmu9DcNObmraG72@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=acc@openeuler.org \
--cc=arnd@arndb.de \
--cc=herbert@gondor.apana.org.au \
--cc=iommu@lists.linux.dev \
--cc=jean-philippe@linaro.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shenyang39@huawei.com \
--cc=wangzhou1@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).