From: Alan Stern <stern@rowland.harvard.edu>
To: Neal Liu <neal_liu@aspeedtech.com>
Cc: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Roger Quadros <roger.quadros@nokia.com>,
Miaohe Lin <linmiaohe@huawei.com>,
Wesley Cheng <quic_wcheng@quicinc.com>,
"Eric W . Biederman" <ebiederm@xmission.com>,
Matthew Wilcox <willy@infradead.org>,
Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
Cai Huoqing <cai.huoqing@linux.dev>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
BMC-SW <BMC-SW@aspeedtech.com>
Subject: Re: [PATCH v2] usb: gadget: f_mass_storage: Make CD-ROM emulation works with Windows OS
Date: Mon, 27 Jun 2022 10:54:14 -0400 [thread overview]
Message-ID: <YrnEli0fdOERpIXe@rowland.harvard.edu> (raw)
In-Reply-To: <HK0PR06MB320272ACB1CA4ADFF8DDABC080B99@HK0PR06MB3202.apcprd06.prod.outlook.com>
On Mon, Jun 27, 2022 at 02:56:40AM +0000, Neal Liu wrote:
> > On Fri, Jun 24, 2022 at 10:19:16AM +0800, Neal Liu wrote:
> > > Add read TOC with format 1 to support CD-ROM emulation with Windows
> > > OS.
> > > This patch is tested on Windows OS Server 2019.
> > >
> > > Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
> > > ---
> > > drivers/usb/gadget/function/f_mass_storage.c | 5 +++--
> > > 1 file changed, 3 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/usb/gadget/function/f_mass_storage.c
> > > b/drivers/usb/gadget/function/f_mass_storage.c
> > > index 3a77bca0ebe1..9edf76c22605 100644
> > > --- a/drivers/usb/gadget/function/f_mass_storage.c
> > > +++ b/drivers/usb/gadget/function/f_mass_storage.c
> > > @@ -1209,7 +1209,8 @@ static int do_read_toc(struct fsg_common
> > > *common, struct fsg_buffhd *bh)
> > >
> > > switch (format) {
> > > case 0:
> > > - /* Formatted TOC */
> > > + case 1:
> > > + /* Formatted TOC, Session info */
> >
> > This comment is a little misleading. 0 is formatted TOC, and 1 is
> > multi-session info. The way you wrote it, it looks like the comment applies to
> > both formats. Do it like this:
> >
> > case 0: /* Formatted TOC */
> > case 1: /* Multi-session info */
> >
>
> Okay, looks more clear. I'll fix it in next patch.
>
> > > len = 4 + 2*8; /* 4 byte header + 2 descriptors */
> > > memset(buf, 0, len);
> > > buf[1] = len - 2; /* TOC Length excludes length field */
> >
> > It looks like you ignored one of the problems I pointed out in my earlier email:
> >
> > > When format is 1, the driver is supposed to ignore the start_track
> > > value. Your patch does not do this.
> >
> > Please fix this.
> >
>
> Do you mean ignore the "start_track > 1" above?
Yes, that's what I mean.
> Do this check only for format 0? Or format 0 & 2?
According to the MMC spec, the Track/Session Number is ignored for
format 1. For format 0 it is valid as a Track Number, and for format 2
it is valid as a Session Number. Therefore it should be checked for
formats 0 and 2 but not for format 1.
Alan Stern
next prev parent reply other threads:[~2022-06-27 14:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 2:19 [PATCH v2] usb: gadget: f_mass_storage: Make CD-ROM emulation works with Windows OS Neal Liu
2022-06-24 6:46 ` Greg Kroah-Hartman
2022-06-27 2:31 ` Neal Liu
2022-06-24 6:46 ` Greg Kroah-Hartman
2022-06-24 14:26 ` Alan Stern
2022-06-27 2:56 ` Neal Liu
2022-06-27 14:54 ` Alan Stern [this message]
2022-06-28 1:57 ` Neal Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrnEli0fdOERpIXe@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=BMC-SW@aspeedtech.com \
--cc=balbi@kernel.org \
--cc=cai.huoqing@linux.dev \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neal_liu@aspeedtech.com \
--cc=nikita.yoush@cogentembedded.com \
--cc=quic_wcheng@quicinc.com \
--cc=roger.quadros@nokia.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).