linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Oded Gabbay <ogabbay@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/12] Adding Gaudi2 ASIC support to habanalabs driver
Date: Tue, 28 Jun 2022 14:20:04 +0200	[thread overview]
Message-ID: <Yrrx9NBjVxmv3IFD@kroah.com> (raw)
In-Reply-To: <20220628105958.1254875-1-ogabbay@kernel.org>

On Tue, Jun 28, 2022 at 01:59:46PM +0300, Oded Gabbay wrote:
> I'm sending the v2 of this patch-set after fixing some comments from Greg.
> 
> Changes to each patch are detailed in the relevant patches.
> 
> Patch 6 was added to remove obsolete elements from the device structure.
> 
> Patch 11 in the 1st patch-set, the TPM patch, was removed due to some points
> that Greg raised and I need to investigate and come back with answers.
> 
> Original cover-letter:
> 
> This patch-set adds support for initializing and sending workloads to
> habanalabs next-gen deep-learning training accelerator ASIC, called Gaudi2.
> 
> The Gaudi2 ASIC is based on the same architecture as the Gaudi ASIC and
> therefore, the driver's common code is applicable to it with only a few
> changes. Almost all of the code included in this patch-set is the
> ASIC-depedent code which is different per ASIC.
> 
> The patches details are as follows:
> 
> - Patch 1 adds the necessary registers header files. I took great care of
>   reducing this amount to minimum.
> 
> - Patch 2 adds the Gaudi2 definitions to the uapi file.
> 
> - Patch 3 adds the bulk of the Gaudi2 asic-specific code.
> 
> - Patches 4-6 modify the existing code to initialize the new asic-specific
>   functions and properties and to remove unused elements.
> 
> - Patch 7 adds a generic security module that will be used by Gaudi2, and
>   future ASICs, to initialize the security mechanisms of the device in a
>   common way.
> 
> - Patches 8-11 add various features of Gaudi2 in asic-specific and common code.
> 
> - Patch 12 enables the Gaudi2 code in the driver.
> 
> More details on Gaudi2 Hardware can be found here:
> https://habana.ai/wp-content/uploads/pdf/2022/gaudi2-whitepaper.pdf
> 
> We have already uploaded the updated LLVM compiler for our TPC engine to:
> https://github.com/HabanaAI/tpc_llvm/tree/v1.1.0
> 
> And we are currently working on updating the open-source SynapseAI Core to
> submit workloads to Gaudi2 via the driver.

Look good to me, thanks for the changes!

greg k-h

      parent reply	other threads:[~2022-06-28 12:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-28 10:59 [PATCH v2 00/12] Adding Gaudi2 ASIC support to habanalabs driver Oded Gabbay
2022-06-28 10:59 ` [PATCH v2 01/12] habanalabs/gaudi2: add asic registers header files Oded Gabbay
2022-06-28 10:59 ` [PATCH v2 02/12] uapi: habanalabs: add gaudi2 defines Oded Gabbay
2022-06-28 10:59 ` [PATCH v2 03/12] habanalabs: add gaudi2 asic-specific code Oded Gabbay
2022-06-28 10:59 ` [PATCH v2 04/12] habanalabs: add unsupported functions Oded Gabbay
2022-06-28 10:59 ` [PATCH v2 05/12] habanalabs: initialize new asic properties Oded Gabbay
2022-06-28 10:59 ` [PATCH v2 06/12] habanalabs: remove obsolete device variables used for testing Oded Gabbay
2022-06-28 10:59 ` [PATCH v2 07/12] habanalabs: add generic security module Oded Gabbay
2022-06-28 10:59 ` [PATCH v2 08/12] habanalabs/gaudi2: add gaudi2 " Oded Gabbay
2022-06-28 10:59 ` [PATCH v2 09/12] habanalabs/gaudi2: add gaudi2 profiler module Oded Gabbay
2022-06-28 10:59 ` [PATCH v2 10/12] habanalabs: add gaudi2 wait-for-CS support Oded Gabbay
2022-06-28 10:59 ` [PATCH v2 11/12] habanalabs: add gaudi2 MMU support Oded Gabbay
2022-06-28 10:59 ` [PATCH v2 12/12] habanalabs: enable gaudi2 code in driver Oded Gabbay
2022-06-28 12:20 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yrrx9NBjVxmv3IFD@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ogabbay@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).