From: Muchun Song <songmuchun@bytedance.com>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: akpm@linux-foundation.org, shy828301@gmail.com,
willy@infradead.org, zokeefe@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 16/16] mm/huge_memory: use helper macro IS_ERR_OR_NULL in split_huge_pages_pid
Date: Tue, 28 Jun 2022 22:54:53 +0800 [thread overview]
Message-ID: <YrsWPVB8TSLSM7zf@FVFYT0MHHV2J.googleapis.com> (raw)
In-Reply-To: <20220628132835.8925-17-linmiaohe@huawei.com>
On Tue, Jun 28, 2022 at 09:28:35PM +0800, Miaohe Lin wrote:
> Use helper macro IS_ERR_OR_NULL to check the validity of page to simplify
> the code. Minor readability improvement.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Thanks.
prev parent reply other threads:[~2022-06-28 14:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 13:28 [PATCH v2 00/16] A few cleanup patches for huge_memory Miaohe Lin
2022-06-28 13:28 ` [PATCH v2 01/16] mm/huge_memory: use flush_pmd_tlb_range in move_huge_pmd Miaohe Lin
2022-06-28 13:28 ` [PATCH v2 02/16] mm/huge_memory: access vm_page_prot with READ_ONCE in remove_migration_pmd Miaohe Lin
2022-06-28 13:28 ` [PATCH v2 03/16] mm/huge_memory: fix comment of __pud_trans_huge_lock Miaohe Lin
2022-06-28 13:28 ` [PATCH v2 04/16] mm/huge_memory: use helper touch_pud in huge_pud_set_accessed Miaohe Lin
2022-06-28 14:59 ` Muchun Song
2022-06-29 2:17 ` Miaohe Lin
2022-06-28 13:28 ` [PATCH v2 05/16] mm/huge_memory: use helper touch_pmd in huge_pmd_set_accessed Miaohe Lin
2022-06-28 15:01 ` Muchun Song
2022-06-28 13:28 ` [PATCH v2 06/16] mm/huge_memory: rename mmun_start to haddr in remove_migration_pmd Miaohe Lin
2022-06-28 13:28 ` [PATCH v2 07/16] mm/huge_memory: use helper function vma_lookup in split_huge_pages_pid Miaohe Lin
2022-06-28 13:28 ` [PATCH v2 08/16] mm/huge_memory: use helper macro __ATTR_RW Miaohe Lin
2022-06-28 13:28 ` [PATCH v2 09/16] mm/huge_memory: fix comment in zap_huge_pud Miaohe Lin
2022-06-28 13:28 ` [PATCH v2 10/16] mm/huge_memory: check pmd_present first in is_huge_zero_pmd Miaohe Lin
2022-06-28 13:28 ` [PATCH v2 11/16] mm/huge_memory: try to free subpage in swapcache when possible Miaohe Lin
2022-06-28 13:28 ` [PATCH v2 12/16] mm/huge_memory: minor cleanup for split_huge_pages_all Miaohe Lin
2022-06-28 13:28 ` [PATCH v2 13/16] mm/huge_memory: fix comment of page_deferred_list Miaohe Lin
2022-06-28 13:28 ` [PATCH v2 14/16] mm/huge_memory: correct comment of prep_transhuge_page Miaohe Lin
2022-06-28 13:28 ` [PATCH v2 15/16] mm/huge_memory: comment the subtly logic in __split_huge_pmd Miaohe Lin
2022-06-28 13:28 ` [PATCH v2 16/16] mm/huge_memory: use helper macro IS_ERR_OR_NULL in split_huge_pages_pid Miaohe Lin
2022-06-28 14:54 ` Muchun Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrsWPVB8TSLSM7zf@FVFYT0MHHV2J.googleapis.com \
--to=songmuchun@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shy828301@gmail.com \
--cc=willy@infradead.org \
--cc=zokeefe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).