From: Wolfram Sang <wsa@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Alain Volmat <alain.volmat@foss.st.com>,
mark.rutland@arm.com, pierre-yves.mordret@foss.st.com,
mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, fabrice.gasnier@foss.st.com,
amelie.delaunay@foss.st.com
Subject: Re: [PATCH 1/4] dt-bindings: i2c: st,stm32-i2c: don't mandate a reset line
Date: Wed, 29 Jun 2022 21:44:37 +0200 [thread overview]
Message-ID: <YryrpbBKsAKcL865@shikoro> (raw)
In-Reply-To: <20220628134115.GA345270-robh@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1241 bytes --]
On Tue, Jun 28, 2022 at 07:41:15AM -0600, Rob Herring wrote:
> On Mon, Jun 20, 2022 at 12:54:02PM +0200, Alain Volmat wrote:
> > Update the dt-bindings of the i2c-stm32 drivers to avoid the
> > needs for a reset property in the device-tree.
>
> That is clear from the diff, but why. Some chips don't have a reset?
> If so, this should be combined with patch 2 as part of changes needed
> for a new version.
What do you mean? Patches 1+2 should be squashed together? I can do this
when applying. Or do you mean something else?
>
> >
> > Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
> > ---
> > Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> > index dccbb18b6dc0..8879144fbbfb 100644
> > --- a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> > @@ -94,7 +94,6 @@ required:
> > - compatible
> > - reg
> > - interrupts
> > - - resets
> > - clocks
> >
> > unevaluatedProperties: false
> > --
> > 2.25.1
> >
> >
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-06-29 19:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 10:54 [PATCH 0/4] i2c: stm32: addition of STM32MP13 support Alain Volmat
2022-06-20 10:54 ` [PATCH 1/4] dt-bindings: i2c: st,stm32-i2c: don't mandate a reset line Alain Volmat
2022-06-28 13:41 ` Rob Herring
2022-06-29 19:44 ` Wolfram Sang [this message]
2022-07-06 22:46 ` Rob Herring
2022-07-07 6:38 ` Alain Volmat
2022-06-20 10:54 ` [PATCH 2/4] i2c: stm32: only perform a reset if there is a reset property Alain Volmat
2022-06-21 13:39 ` Pierre Yves MORDRET
2022-06-20 10:54 ` [PATCH 3/4] dt-bindings: i2c: st,stm32-i2c: add entry for stm32mp13 Alain Volmat
2022-06-20 10:54 ` [PATCH 4/4] i2c: stm32: add support for the STM32MP13 soc Alain Volmat
2022-06-21 13:40 ` Pierre Yves MORDRET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YryrpbBKsAKcL865@shikoro \
--to=wsa@kernel.org \
--cc=alain.volmat@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=amelie.delaunay@foss.st.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@foss.st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=pierre-yves.mordret@foss.st.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).