From: Jiri Olsa <olsajiri@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Jiri Olsa <olsajiri@gmail.com>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexei Starovoitov <ast@kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Sedat Dilek <sedat.dilek@gmail.com>,
Quentin Monnet <quentin@isovalent.com>
Subject: Re: [PATCH v2 0/5] tools: fix compilation failure caused by init_disassemble_info API changes
Date: Tue, 5 Jul 2022 00:12:37 +0200 [thread overview]
Message-ID: <YsNl1XdEuxvqb3vx@krava> (raw)
In-Reply-To: <20220704201922.pvrh4cmmjxjn4mkx@awork3.anarazel.de>
On Mon, Jul 04, 2022 at 01:19:22PM -0700, Andres Freund wrote:
> Hi,
>
> On 2022-07-04 11:13:33 +0200, Jiri Olsa wrote:
> > I think the disassembler checks should not be displayed by default,
> > with your change I can see all the time:
> >
> > ... disassembler-four-args: [ on ]
> > ... disassembler-init-styled: [ OFF ]
> >
> >
> > could you please squash something like below in? moving disassembler
> > checks out of sight and do manual detection
>
> Makes sense - I was wondering why disassembler-four-args is displayed, but
> though it better to mirror the existing behaviour. Does "hiding"
> disassembler-four-args need to be its own set of commits?
I guess first hide the disassembler-four-args and add the new the same way
>
>
> > diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> > index ee417c321adb..2aa0bad11f05 100644
> > --- a/tools/perf/Makefile.config
> > +++ b/tools/perf/Makefile.config
> > @@ -914,8 +914,6 @@ ifndef NO_LIBBFD
> > FEATURE_CHECK_LDFLAGS-disassembler-init-styled += -liberty -lz -ldl
> > endif
> > endif
> > - $(call feature_check,disassembler-four-args)
> > - $(call feature_check,disassembler-init-styled)
> > endif
> >
> > ifeq ($(feature-libbfd-buildid), 1)
> > @@ -1025,6 +1023,9 @@ ifdef HAVE_KVM_STAT_SUPPORT
> > CFLAGS += -DHAVE_KVM_STAT_SUPPORT
> > endif
> >
> > +$(call feature_check,disassembler-four-args)
> > +$(call feature_check,disassembler-init-styled)
> > +
> > ifeq ($(feature-disassembler-four-args), 1)
> > CFLAGS += -DDISASM_FOUR_ARGS_SIGNATURE
> > endif
>
> This I don't understand - why do we want these to run under NO_LIBBFD etc?
when I was quickly testing that I did not have any of them detected
and got compile fail.. so I moved it to safe place ;-) it might be
placed in smarter place
thanks,
jirka
>
> Greetings,
>
> Andres Freund
next prev parent reply other threads:[~2022-07-04 22:12 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 18:19 init_disassemble_info() signature changes causes compile failures Andres Freund
2022-06-22 22:53 ` Quentin Monnet
2022-06-22 23:16 ` Andres Freund
2022-06-23 9:49 ` Andrew Burgess
2022-07-03 4:48 ` [PATCH v1 0/3] tools: fix compilation failure caused by init_disassemble_info API changes Andres Freund
2022-07-03 4:48 ` [PATCH v1 1/3] tools build: add feature test for " Andres Freund
2022-07-03 4:48 ` [PATCH v1 2/3] tools: add dis-asm-compat.h to centralize handling of version differences Andres Freund
2022-07-03 4:48 ` [PATCH v1 2/3] tools: introduce dis-asm.h wrapper to hide " Andres Freund
2022-07-03 4:54 ` Andres Freund
2022-07-03 4:48 ` [PATCH v1 3/3] tools: Use tools/dis-asm-compat.h to fix compilation errors with new binutils Andres Freund
2022-07-03 21:25 ` [PATCH v2 0/5] tools: fix compilation failure caused by init_disassemble_info API changes Andres Freund
2022-07-03 21:25 ` [PATCH v2 1/5] tools build: add feature test for " Andres Freund
2022-07-03 21:25 ` [PATCH v2 2/5] tools include: add dis-asm-compat.h to handle version differences Andres Freund
2022-07-05 13:44 ` Quentin Monnet
2022-07-15 19:39 ` Andres Freund
2022-07-15 19:46 ` Andres Freund
2022-07-18 8:58 ` Quentin Monnet
2022-07-03 21:25 ` [PATCH v2 3/5] tools perf: Fix compilation error with new binutils Andres Freund
2022-07-03 21:25 ` [PATCH v2 4/5] tools bpf_jit_disasm: " Andres Freund
2022-07-03 21:25 ` [PATCH v2 5/5] tools bpftool: " Andres Freund
2022-07-04 9:13 ` [PATCH v2 0/5] tools: fix compilation failure caused by init_disassemble_info API changes Jiri Olsa
2022-07-04 20:19 ` Andres Freund
2022-07-04 22:12 ` Jiri Olsa [this message]
2022-08-01 1:40 ` Andres Freund
2022-07-10 11:43 ` Sedat Dilek
2022-07-10 17:52 ` Sedat Dilek
2022-07-14 9:16 ` Sedat Dilek
2022-07-14 13:25 ` Ben Hutchings
2022-07-15 19:16 ` Andres Freund
2022-07-15 19:18 ` Ben Hutchings
2022-08-01 18:08 ` Arnaldo Carvalho de Melo
2022-07-27 15:47 ` Arnaldo Carvalho de Melo
2022-07-30 21:45 ` Andres Freund
2022-08-01 1:38 ` [PATCH v3 0/8] " Andres Freund
2022-08-01 1:38 ` [PATCH v3 1/8] tools build: Add feature test for " Andres Freund
2022-08-01 1:38 ` [PATCH v3 2/8] tools build: Don't display disassembler-four-args feature test Andres Freund
2022-08-01 18:10 ` Arnaldo Carvalho de Melo
2022-08-01 1:38 ` [PATCH v3 3/8] tools include: add dis-asm-compat.h to handle version differences Andres Freund
2022-08-01 18:05 ` Arnaldo Carvalho de Melo
2022-08-01 18:10 ` Andres Freund
2022-08-01 1:38 ` [PATCH v3 4/8] tools perf: Fix compilation error with new binutils Andres Freund
2022-08-01 1:38 ` [PATCH v3 5/8] tools bpf_jit_disasm: " Andres Freund
2022-08-01 1:38 ` [PATCH v3 6/8] tools bpf_jit_disasm: Don't display disassembler-four-args feature test Andres Freund
2022-08-01 18:27 ` Arnaldo Carvalho de Melo
2022-08-01 18:41 ` Andres Freund
2022-08-01 1:38 ` [PATCH v3 7/8] tools bpftool: Fix compilation error with new binutils Andres Freund
2022-08-01 1:38 ` [PATCH v3 8/8] tools bpftool: Don't display disassembler-four-args feature test Andres Freund
2022-08-01 18:28 ` Arnaldo Carvalho de Melo
2022-08-01 12:45 ` [PATCH v3 0/8] tools: fix compilation failure caused by init_disassemble_info API changes Arnaldo Carvalho de Melo
2022-08-01 15:15 ` Quentin Monnet
2022-08-01 18:02 ` Arnaldo Carvalho de Melo
2022-08-08 13:35 ` Daniel Borkmann
2022-08-01 19:53 ` Jiri Olsa
2022-08-01 19:12 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsNl1XdEuxvqb3vx@krava \
--to=olsajiri@gmail.com \
--cc=acme@redhat.com \
--cc=andres@anarazel.de \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quentin@isovalent.com \
--cc=sedat.dilek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).