From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C90AC43334 for ; Wed, 6 Jul 2022 22:27:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233928AbiGFW1Q (ORCPT ); Wed, 6 Jul 2022 18:27:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233947AbiGFW1O (ORCPT ); Wed, 6 Jul 2022 18:27:14 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 646142B1A6 for ; Wed, 6 Jul 2022 15:27:13 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id bh13so9239982pgb.4 for ; Wed, 06 Jul 2022 15:27:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8En5VcDzJpRZUJVBlGHl7Q0Kg1P7kPCrXjhE+LYfN5M=; b=kUIIVGCvERQEwyak3xqYOSlBxS1t7NuI8dhRO8VQaU9LIJ4OHWPVFlkNrzzG8/4+4h 9bMaqgsk8h471N0EWcKC28ueATACcd427UQJ08RGW/XfwbnTa9KOCj6Gj5+JKtgkIYNg mV42Sjkr8T7U+CFhVFGY2RkyxyF1dHwogJs/8kX8bMg77uOzJehO6zidjkXV+rS4rx28 aX5yARkMcygsr/w43e7dqgSElHUG8h+okUWK+0TP0E7BCzKWbPcwMXc08LxXEtzyKbNl 9oG04V8LDumUHN+BuX8c1em1gW0L+Y2EwVQw3ihOm5eJlblVDdaqBA/R8rsisN0ySVGr ownA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8En5VcDzJpRZUJVBlGHl7Q0Kg1P7kPCrXjhE+LYfN5M=; b=ffhyUbnLEX7D1kv8k0os3bPzetsXe1J9sgZvGFaGvovlq3qcwt07ikcAxttwDyk2+k o+6DqYC/iXQJzlV4+TRPjZ2oaDu7QyyWY3aSvmiyL3pQqeMuB3QiY7Y6G4TwDbA3ORcF aT3wlIphvh2zX2Rfzl29j/ER84/Ne4jDImInyofTheZCGySki0SQl4AkBs2/3w4TXxoy zDX0m6cHipd/Nro/ld3FGu6I4JGwzORUtbzZOEiA91QeJIxEmCRtW1U2X7w9Yu1ZXvHz EltCqqr65DQ6nlLNREPFKqUkDcFRToNPoUPFDgy8uP/fH+lcyxLEVq85PKW5+KFy6XPi 7ysA== X-Gm-Message-State: AJIora+2SlXmRLjK+CMtKnQn0KJWkS36husEgj9apk8vTPyRgNQjpoG7 tXfLLihRR4+h7nlOCA3To0mZxw== X-Google-Smtp-Source: AGRyM1vHvu+U2FyKN0UOsLIZn0q60hIVl9H32PwcOuMvAe5bhsFNxwgb8QQ+Rs8X2STgT9XFwF4Qyw== X-Received: by 2002:a17:902:f708:b0:153:839f:bf2c with SMTP id h8-20020a170902f70800b00153839fbf2cmr49549892plo.113.1657146432846; Wed, 06 Jul 2022 15:27:12 -0700 (PDT) Received: from google.com (123.65.230.35.bc.googleusercontent.com. [35.230.65.123]) by smtp.gmail.com with ESMTPSA id e17-20020aa798d1000000b00525496442ccsm25310656pfm.216.2022.07.06.15.27.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 15:27:12 -0700 (PDT) Date: Wed, 6 Jul 2022 22:27:08 +0000 From: Sean Christopherson To: Vitaly Kuznetsov Cc: kvm@vger.kernel.org, Paolo Bonzini , Anirudh Rayabharam , Wanpeng Li , Jim Mattson , Maxim Levitsky , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 13/28] KVM: VMX: Get rid of eVMCS specific VMX controls sanitization Message-ID: References: <20220629150625.238286-1-vkuznets@redhat.com> <20220629150625.238286-14-vkuznets@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220629150625.238286-14-vkuznets@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 29, 2022, Vitaly Kuznetsov wrote: > With the updated eVMCSv1 definition, there's no known 'problematic' > controls which are exposed in VMX control MSRs but are not present in > eVMCSv1. Get rid of the filtering. Ah, this patch is confusing until one realizes that this is dropping the "filtering" for what controls/features _KVM_ uses, whereas nested_evmcs_filter_control_msr() filters controls that are presented to L1. Can you add something to clarify that in the changelog?