From: Sean Christopherson <seanjc@google.com>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
Zefan Li <lizefan.x@bytedance.com>, Marc Zyngier <maz@kernel.org>,
James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeelb@google.com>,
Oliver Upton <oupton@google.com>,
Huang@google.com, Shaoqin <shaoqin.huang@intel.com>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v6 1/4] mm: add NR_SECONDARY_PAGETABLE to count secondary page table uses.
Date: Thu, 7 Jul 2022 20:59:41 +0000 [thread overview]
Message-ID: <YsdJPeVOqlj4cf2a@google.com> (raw)
In-Reply-To: <20220628220938.3657876-2-yosryahmed@google.com>
On Tue, Jun 28, 2022, Yosry Ahmed wrote:
> We keep track of several kernel memory stats (total kernel memory, page
> tables, stack, vmalloc, etc) on multiple levels (global, per-node,
> per-memcg, etc). These stats give insights to users to how much memory
> is used by the kernel and for what purposes.
>
> Currently, memory used by kvm mmu is not accounted in any of those
Nit, capitalize KVM (mainly to be consistent).
> @@ -1085,6 +1086,9 @@ KernelStack
> Memory consumed by the kernel stacks of all tasks
> PageTables
> Memory consumed by userspace page tables
> +SecPageTables
> + Memory consumed by secondary page tables, this currently
> + currently includes KVM mmu allocations on x86 and arm64.
Nit, this line has a tab instead of eight spaces. Not sure if it actually matters,
there are plenty of tabs elsewhere in the file, but all the entries in this block
use only spaces.
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index aab70355d64f3..13190d298c986 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -216,6 +216,7 @@ enum node_stat_item {
> NR_KERNEL_SCS_KB, /* measured in KiB */
> #endif
> NR_PAGETABLE, /* used for pagetables */
> + NR_SECONDARY_PAGETABLE, /* secondary pagetables, e.g. kvm shadow pagetables */
Nit, s/kvm/KVM, and drop the "shadow", which might be misinterpreted as saying KVM
pagetables are only accounted when KVM is using shadow paging. KVM's usage of "shadow"
is messy, so I totally understand why you included it, but in this case it's unnecessary
and potentially confusing.
And finally, something that's not a nit. Should this be wrapped with CONFIG_KVM
(using IS_ENABLED() because KVM can be built as a module)? That could be removed
if another non-KVM secondary MMU user comes along, but until then, #ifdeffery for
stats the depend on a single feature seems to be the status quo for this code.
> #ifdef CONFIG_SWAP
> NR_SWAPCACHE,
> #endif
next prev parent reply other threads:[~2022-07-07 20:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 22:09 [PATCH v6 0/4] KVM: mm: count KVM mmu usage in memory stats Yosry Ahmed
2022-06-28 22:09 ` [PATCH v6 1/4] mm: add NR_SECONDARY_PAGETABLE to count secondary page table uses Yosry Ahmed
2022-06-29 10:29 ` Marc Zyngier
2022-07-07 20:59 ` Sean Christopherson [this message]
2022-07-12 23:03 ` Yosry Ahmed
2022-07-12 23:05 ` Sean Christopherson
2022-07-18 18:26 ` Yosry Ahmed
2022-08-08 20:06 ` Yosry Ahmed
2022-08-15 9:18 ` Yosry Ahmed
2022-08-15 15:13 ` Johannes Weiner
2022-08-15 15:39 ` Yosry Ahmed
2022-08-17 17:25 ` Andrew Morton
2022-08-17 17:24 ` Andrew Morton
2022-08-17 22:27 ` Yosry Ahmed
2022-08-23 0:04 ` Yosry Ahmed
2022-08-23 0:08 ` Andrew Morton
2022-06-28 22:09 ` [PATCH v6 2/4] KVM: mmu: add a helper to account memory used by KVM MMU Yosry Ahmed
2022-06-29 10:30 ` Marc Zyngier
2022-07-07 21:08 ` Sean Christopherson
2022-07-12 23:03 ` Yosry Ahmed
2022-06-28 22:09 ` [PATCH v6 3/4] KVM: x86/mmu: count KVM mmu usage in secondary pagetable stats Yosry Ahmed
2022-07-07 21:11 ` Sean Christopherson
2022-06-28 22:09 ` [PATCH v6 4/4] KVM: arm64/mmu: count KVM s2 " Yosry Ahmed
2022-06-29 10:30 ` Marc Zyngier
2022-06-30 21:01 ` [PATCH v6 0/4] KVM: mm: count KVM mmu usage in memory stats Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsdJPeVOqlj4cf2a@google.com \
--to=seanjc@google.com \
--cc=Huang@google.com \
--cc=akpm@linux-foundation.org \
--cc=alexandru.elisei@arm.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=james.morse@arm.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=maz@kernel.org \
--cc=mhocko@kernel.org \
--cc=oupton@google.com \
--cc=pbonzini@redhat.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=shaoqin.huang@intel.com \
--cc=suzuki.poulose@arm.com \
--cc=tj@kernel.org \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).