From: Greg KH <gregkh@linuxfoundation.org>
To: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Nobuhiro Iwamatsu" <nobuhiro1.iwamatsu@toshiba.co.jp>,
"Jonathan Corbet" <corbet@lwn.net>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH v2 0/5] Add Toshiba Visconti DNN image processing accelerator driver
Date: Mon, 25 Jul 2022 14:46:59 +0200 [thread overview]
Message-ID: <Yt6Qw/r0FQ0ElYdn@kroah.com> (raw)
In-Reply-To: <20220722082858.17880-1-yuji2.ishikawa@toshiba.co.jp>
On Fri, Jul 22, 2022 at 05:28:53PM +0900, Yuji Ishikawa wrote:
> This series is the DNN image processing accelerator driver for Toshiba's ARM SoC, Visconti[0].
> This provides DT binding documentation, device driver, MAINTAINER files and documents.
>
> Best regards,
> Yuji
>
> [0]: https://toshiba.semicon-storage.com/ap-en/semiconductor/product/image-recognition-processors-visconti.html
>
> dt-bindings: soc: visconti: Add Toshiba Visconti DNN image processing accelerator bindings
> v1 -> v2:
> - No update
>
> soc: visconti: Add Toshiba Visconti image processing accelerator common source
> v1 -> v2:
> - checked with checkpatch.pl --strict
>
> soc: visconti: Add Toshiba Visconti DNN image processing accelerator
> v1 -> v2:
> - checked with checkpatch.pl --strict
> - removed unused code
>
> MAINTAINERS: Add entries for Toshiba Visconti DNN image processing
> v1 -> v2:
> - No update
>
> Documentation: driver-api: visconti: add a description of DNN driver.
> v1 -> v2:
> - newly added documents
>
> Yuji Ishikawa (5):
> dt-bindings: soc: visconti: Add Toshiba Visconti DNN image processing
> accelerator bindings
> soc: visconti: Add Toshiba Visconti image processing accelerator
> common source
> soc: visconti: Add Toshiba Visconti DNN image processing accelerator
> MAINTAINERS: Add entries for Toshiba Visconti DNN image processing
> accelerator
> Documentation: driver-api: visconti: add a description of DNN driver.
>
> .../soc/visconti/toshiba,visconti-dnn.yaml | 54 ++
> Documentation/driver-api/visconti/common.rst | 115 ++++
> Documentation/driver-api/visconti/dnn.rst | 394 +++++++++++++
> MAINTAINERS | 2 +
> drivers/soc/Kconfig | 1 +
> drivers/soc/Makefile | 1 +
> drivers/soc/visconti/Kconfig | 7 +
> drivers/soc/visconti/Makefile | 8 +
> drivers/soc/visconti/dnn/Makefile | 6 +
> drivers/soc/visconti/dnn/dnn.c | 523 ++++++++++++++++++
> drivers/soc/visconti/dnn/hwd_dnn.c | 183 ++++++
> drivers/soc/visconti/dnn/hwd_dnn.h | 68 +++
> drivers/soc/visconti/dnn/hwd_dnn_reg.h | 228 ++++++++
> drivers/soc/visconti/ipa_common.c | 55 ++
> drivers/soc/visconti/ipa_common.h | 18 +
> drivers/soc/visconti/uapi/dnn.h | 77 +++
> drivers/soc/visconti/uapi/ipa.h | 90 +++
Why is this in drivers/soc/?
And uapi files belong in the correct include path, not burried in a
driver subdirectory where they will never be picked up correctly by the
build system. How did you test these?
thanks,
greg k-h
next prev parent reply other threads:[~2022-07-25 12:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 8:28 [PATCH v2 0/5] Add Toshiba Visconti DNN image processing accelerator driver Yuji Ishikawa
2022-07-22 8:28 ` [PATCH v2 1/5] dt-bindings: soc: visconti: Add Toshiba Visconti DNN image processing accelerator bindings Yuji Ishikawa
2022-07-22 8:28 ` [PATCH v2 2/5] soc: visconti: Add Toshiba Visconti image processing accelerator common source Yuji Ishikawa
2022-07-25 12:46 ` Greg KH
2022-07-26 7:02 ` yuji2.ishikawa
2022-07-22 8:28 ` [PATCH v2 3/5] soc: visconti: Add Toshiba Visconti DNN image processing accelerator Yuji Ishikawa
2022-07-25 12:48 ` Greg KH
2022-07-26 6:10 ` yuji2.ishikawa
2022-07-25 12:50 ` Greg KH
2022-07-26 6:10 ` yuji2.ishikawa
2022-07-26 15:15 ` Greg KH
2022-07-22 8:28 ` [PATCH v2 4/5] MAINTAINERS: Add entries for " Yuji Ishikawa
2022-07-25 12:47 ` Greg KH
2022-07-26 6:10 ` yuji2.ishikawa
2022-07-28 8:46 ` Greg KH
2022-07-22 8:28 ` [PATCH v2 5/5] Documentation: driver-api: visconti: add a description of DNN driver Yuji Ishikawa
2022-07-22 13:32 ` Jonathan Corbet
2022-07-26 6:10 ` yuji2.ishikawa
2022-07-25 12:46 ` Greg KH [this message]
2022-07-26 6:09 ` [PATCH v2 0/5] Add Toshiba Visconti DNN image processing accelerator driver yuji2.ishikawa
2022-07-28 8:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yt6Qw/r0FQ0ElYdn@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=christian.koenig@amd.com \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=hverkuil@xs4all.nl \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=robh+dt@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=yuji2.ishikawa@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).