From: Vincent Donnefort <vdonnefort@google.com>
To: Valentin Schneider <vschneid@redhat.com>
Cc: peterz@infradead.org, tglx@linutronix.de,
linux-kernel@vger.kernel.org, regressions@leemhuis.info,
kernel-team@android.com, Derek Dolney <z23@posteo.net>
Subject: Re: [PATCH v5] cpu/hotplug: Do not bail-out in DYING/STARTING sections
Date: Mon, 25 Jul 2022 16:16:10 +0100 [thread overview]
Message-ID: <Yt6zuvatUa0gtYjn@google.com> (raw)
In-Reply-To: <xhsmh1qu9fcxo.mognet@vschneid.remote.csb>
On Mon, Jul 25, 2022 at 04:07:47PM +0100, Valentin Schneider wrote:
> On 25/07/22 10:59, Vincent Donnefort wrote:
> > The DYING/STARTING callbacks are not expected to fail. However, as reported
> > by Derek, drivers such as tboot are still free to return errors within
> > those sections, which halts the hot(un)plug and leaves the CPU in an
> > unrecoverable state.
> >
> > No rollback being possible there, let's only log the failures and proceed
> > with the following steps. This restores the hotplug behaviour prior to
> > commit 453e41085183 ("cpu/hotplug: Add cpuhp_invoke_callback_range()")
> >
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=215867
> > Fixes: 453e41085183 ("cpu/hotplug: Add cpuhp_invoke_callback_range()")
> > Reported-by: Derek Dolney <z23@posteo.net>
> > Signed-off-by: Vincent Donnefort <vdonnefort@google.com>
> > Tested-by: Derek Dolney <z23@posteo.net>
> >
>
> The changelog has some undesired stowaways below, but regardless:
> Reviewed-by: Valentin Schneider <vschneid@redhat.com>
Arg indeed, my bad. But thanks for the tag!
>
> > v4 -> v5:
> > - Remove WARN, only log broken states with pr_warn.
> > v3 -> v4:
> > - Sorry ... wrong commit description style ...
> > v2 -> v3:
> > - Tested-by tag.
> > - Refine commit description.
> > - Bugzilla link.
> > v1 -> v2:
> > - Commit message rewording.
> > - More details in the warnings.
> > - Some variable renaming
> >
>
next prev parent reply other threads:[~2022-07-25 15:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 9:59 [PATCH v5] cpu/hotplug: Do not bail-out in DYING/STARTING sections Vincent Donnefort
2022-07-25 15:07 ` Valentin Schneider
2022-07-25 15:16 ` Vincent Donnefort [this message]
2022-08-17 9:46 ` Thorsten Leemhuis
2022-09-20 9:59 ` Thorsten Leemhuis
2022-09-27 10:05 ` Vincent Donnefort
2022-09-27 10:20 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yt6zuvatUa0gtYjn@google.com \
--to=vdonnefort@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=regressions@leemhuis.info \
--cc=tglx@linutronix.de \
--cc=vschneid@redhat.com \
--cc=z23@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).