From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C471C43334 for ; Mon, 25 Jul 2022 21:25:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237210AbiGYVZs (ORCPT ); Mon, 25 Jul 2022 17:25:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229636AbiGYVZq (ORCPT ); Mon, 25 Jul 2022 17:25:46 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91C3622BFB; Mon, 25 Jul 2022 14:25:45 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id y141so11520222pfb.7; Mon, 25 Jul 2022 14:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qRdczfwqTE1ClSc+nVMd7FDIiV42abVCNkRv2IL8Lek=; b=L6AKMM6K4trb2vONHbs3hxILEtF+2UgNvTe16SDRmYlKVhAG67nRJYhPOPNlejNU9k e3pqftybhinP1UmAAjwe4lAvrRhqOOlTYhZZDByfIDWIL5QunSTgfqoZZnBmIN5Uikdn RPB0p2npCp0f2lnS31YBgavWOG3ReU2zxNJ1DX8upUd7GWJBCbqfL/fZGabxJNwQWIZ3 pvDbMfIp07dcp0vFPjTGQk8oKTyb2WhYwpNbIixgYAyaDtF14E3MyxbjNevn1qD4azBu EsG/W7w4mHpxY6csvkkBX1FMHozd2JAkh1IpTJLXnYEmQOo3qhIuHpNaBWSxaOG/hibm 5xeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qRdczfwqTE1ClSc+nVMd7FDIiV42abVCNkRv2IL8Lek=; b=VL35w5fdnGMuY3iG2s443uEiyKVFSQ5qYxErsMgrY9RXVoNhhHH+a5zxglmwE9nKr8 WlfSsM+Y19Zn8YFWcvkrO/lCBVrA3CYnf0OPAKkYGg5uR6I3vmZ5fg66KBZKy5zl+9N/ 7bshkr43RENpyXuTLNCJwyv8mCCPPug6P2oFmwmGiGB2KqeVN4sBkFIqpq1U9zJHpZx7 bn8RbLANjvrh1C03Xj5pgRaRLqcXItZocauJyObVh9n3iOpGXmCxT4Re8AIRo1njilZU YfzssKWeoCUqaFCP/XkIyMpZTZyYL4rpdcR/ry6lnMWrPgKTboCMsSwKZ9kw2Q1PP20B X0NA== X-Gm-Message-State: AJIora81vgoiYge1s+gUUfSgDG1Nv83WjOXD9PtvbSIMW+O1GjtGPmEY Ll4CpV8SLF/oBnPBHdlw8Q0LuKUG7qcQRg== X-Google-Smtp-Source: AGRyM1sd1c1I+EYc9ZvSrnDP1TC7QERjPcDblbVBFnbkdez9paKN37PMRziYxYw3G13XnAyGRU2PGg== X-Received: by 2002:a63:d711:0:b0:415:c581:2aff with SMTP id d17-20020a63d711000000b00415c5812affmr12701105pgg.278.1658784344817; Mon, 25 Jul 2022 14:25:44 -0700 (PDT) Received: from localhost ([2409:10:24a0:4700:e8ad:216a:2a9d:6d0c]) by smtp.gmail.com with ESMTPSA id d5-20020a170903230500b0016c3b0042d0sm9735220plh.14.2022.07.25.14.25.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jul 2022 14:25:43 -0700 (PDT) Date: Tue, 26 Jul 2022 06:25:42 +0900 From: Stafford Horne To: Bjorn Helgaas Cc: LKML , Arnd Bergmann , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH v3 1/3] asm-generic: Support NO_IOPORT_MAP in pci_iomap.h Message-ID: References: <20220725020737.1221739-2-shorne@gmail.com> <20220725171059.GA5779@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220725171059.GA5779@bhelgaas> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 25, 2022 at 12:10:59PM -0500, Bjorn Helgaas wrote: > On Mon, Jul 25, 2022 at 11:07:35AM +0900, Stafford Horne wrote: > > When building OpenRISC PCI which has no ioport_map we get the following build > > error. > > > > lib/pci_iomap.c: In function 'pci_iomap_range': > > CC drivers/i2c/i2c-core-base.o > > ./include/asm-generic/pci_iomap.h:29:41: error: implicit declaration of function 'ioport_map'; did you mean 'ioremap'? [-Werror=implicit-function-declaration] > > 29 | #define __pci_ioport_map(dev, port, nr) ioport_map((port), (nr)) > > | ^~~~~~~~~~ > > lib/pci_iomap.c:44:24: note: in expansion of macro '__pci_ioport_map' > > 44 | return __pci_ioport_map(dev, start, len); > > | ^~~~~~~~~~~~~~~~ > > > > This patch adds a NULL definition of __pci_ioport_map for architetures > > which do not support ioport_map. > > > > Suggested-by: Arnd Bergmann > > Signed-off-by: Stafford Horne > > FWIW, > > Acked-by: Bjorn Helgaas Thank you, > I assume this will go via some other tree; let me know if otherwise. Yes I plan to send this along with the other patches via the OpenRISC tree. -Stafford