From: Nathan Chancellor <nathan@kernel.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
llvm@lists.linux.dev
Subject: Re: linux-next: Tree for Jul 14
Date: Thu, 14 Jul 2022 14:24:10 -0700 [thread overview]
Message-ID: <YtCJeieW4Mz1VfRx@dev-arch.thelio-3990X> (raw)
In-Reply-To: <CADVatmNOV+jn1WSFo=z4F9KqzYAgxCWr0cxTFL_5myJKFkQNzQ@mail.gmail.com>
Dropping the next list and Stephen as these issues are likely present on
mainline as well.
On Thu, Jul 14, 2022 at 07:26:27PM +0100, Sudip Mukherjee wrote:
> Hi Nathan,
>
> On Thu, Jul 14, 2022 at 5:29 PM Nathan Chancellor <nathan@kernel.org> wrote:
> >
> > On Thu, Jul 14, 2022 at 05:21:32PM +0100, Sudip Mukherjee wrote:
> > > Hi Nathan,
> > >
> > > On Thu, Jul 14, 2022 at 5:05 PM Nathan Chancellor <nathan@kernel.org> wrote:
> > > >
> > > > Hi Sudip,
> > > >
> > > > On Thu, Jul 14, 2022 at 12:07:06PM +0100, Sudip Mukherjee (Codethink) wrote:
> > > > > Hi Stephen,
> > > > >
> > > > > On Thu, Jul 14, 2022 at 06:55:14PM +1000, Stephen Rothwell wrote:
> > > > > > Hi all,
> > > > > >
> > > > > > Changes since 20220713:
> > > > >
> > > > > Build failures on next-20220714:
> > > >
> > > > <snip>
> > > >
>
> <snip>
>
> >
> > Sure! I am not sure that we have tested mips or powerpc allmodconfig now
> > that I am thinking about it but we'll certainly take a look at any
> > issues that come from them and see what we can do.
>
> The build errors from powerpc allmodconfig with clang:
Thanks for testing!
> 1)
> Error: External symbol 'memset' referenced from prom_init.c
Good to know this is not clang specific.
> 2)
> drivers/clk/qcom/gpucc-sm8350.c:111:2: error: initializer element is
> not a compile-time constant
> gpu_cc_parent,
> ^~~~~~~~~~~~~
> drivers/clk/qcom/gpucc-sm8350.c:126:2: error: initializer element is
> not a compile-time constant
> gpu_cc_parent,
> ^~~~~~~~~~~~~
> 3)
> sound/soc/intel/avs/path.c:815:18: error: stack frame size (2672)
> exceeds limit (2048) in 'avs_path_create'
> [-Werror,-Wframe-larger-than]
> struct avs_path *avs_path_create(struct avs_dev *adev, u32 dma_id,
> ^
Right so this one is the one I linked early that impacts arm64 (also
arm and riscv). It appears to be related to KASAN + FORTIFY_SOURCE and I
have a diff that works but I am not sure if it is acceptable. I guess I
should just submit it and see.
> 4)
> drivers/net/ethernet/mellanox/mlx4/main.c:3332:12: error: stack frame
> size (2128) exceeds limit (2048) in 'mlx4_load_one'
> [-Werror,-Wframe-larger-than]
> static int mlx4_load_one(struct pci_dev *pdev, int pci_dev_data,
> ^
> 5)
> In file included from drivers/scsi/BusLogic.c:51:
> drivers/scsi/FlashPoint.c:1712:12: error: stack frame size (2896)
> exceeds limit (2048) in 'FlashPoint_HandleInterrupt'
> [-Werror,-Wframe-larger-than]
> static int FlashPoint_HandleInterrupt(void *pcard)
> ^
> 6)
> drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c:1093:12: error: stack frame size
> (2128) exceeds limit (2048) in 'vcn_v3_0_start'
> [-Werror,-Wframe-larger-than]
I don't see any large variables on the stack in these functions so I am
guessing we are just getting murdered by inlining in combination with
KASAN instrumentation, as KASAN gets turned on by allmodconfig.
Unfortunately, this has been an issue for a long time:
https://github.com/ClangBuiltLinux/linux/issues/39
It has not been as bad with CONFIG_KASAN_STACK force disabled for clang
but it is still there for certain architectures, namely ARCH=arm. I
would be curious to see if all those -Wframe-larger-than instances
disappear with CONFIG_KASAN disabled.
Cheers,
Nathan
next prev parent reply other threads:[~2022-07-14 21:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 8:55 linux-next: Tree for Jul 14 Stephen Rothwell
2022-07-14 11:07 ` Sudip Mukherjee (Codethink)
2022-07-14 16:05 ` Nathan Chancellor
2022-07-14 16:21 ` Sudip Mukherjee
2022-07-14 16:29 ` Nathan Chancellor
2022-07-14 16:55 ` Sudip Mukherjee
2022-07-14 18:26 ` Sudip Mukherjee
2022-07-14 21:24 ` Nathan Chancellor [this message]
2022-07-15 22:06 ` Sudip Mukherjee
2022-07-17 22:05 ` Sudip Mukherjee
2022-07-14 18:51 ` Nick Desaulniers
-- strict thread matches above, loose matches on Subject: below --
2023-07-14 4:15 Stephen Rothwell
2021-07-14 3:25 Stephen Rothwell
2020-07-14 10:03 Stephen Rothwell
2017-07-14 3:58 Stephen Rothwell
2016-07-14 6:18 Stephen Rothwell
2015-07-14 5:41 Stephen Rothwell
2014-07-14 7:17 Stephen Rothwell
2014-07-14 17:50 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtCJeieW4Mz1VfRx@dev-arch.thelio-3990X \
--to=nathan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).