From: Eric Biggers <ebiggers@kernel.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] crypto: lib - move crypto_simd_disabled_for_test into utils
Date: Mon, 18 Jul 2022 21:34:23 -0700 [thread overview]
Message-ID: <YtY0T4qASnYOIjIW@sol.localdomain> (raw)
In-Reply-To: <YtMEFyH8WyPS/vJB@zx2c4.com>
On Sat, Jul 16, 2022 at 08:32:55PM +0200, Jason A. Donenfeld wrote:
> Hi Eric,
>
> On Fri, Jul 15, 2022 at 11:29:20PM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > Move the definition of crypto_simd_disabled_for_test into
> > lib/crypto/utils.c so that it can be accessed by library code.
> >
> > This is needed when code that is shared between a traditional crypto API
> > implementation and a library implementation is built-in, but
> > CRYPTO_ALGAPI=m. The x86 blake2s previously was an example of this
> > (https://lore.kernel.org/linux-crypto/20220517033630.1182-1-gaochao49@huawei.com/T/#u).
> > Although that case was resolved by removing the blake2s shash support,
> > this problem could easily come back in the future, so let's address it.
>
> I'm not sure I see the reason in general for a utility library rather
> than doing these piecemeal like the rest of lib functions. Why is crypto
> special here? But in particular to this patch: nothing is actually using
> crypto_simd_disabled_for_test in lib/crypto, right? So is this
> necessary?
Well, this is what Herbert wanted:
https://lore.kernel.org/r/YtEgzHuuMts0YBCz@gondor.apana.org.au. It's
subjective, but for now I think I prefer this approach too, since the utility
functions are so small and are widely used. A whole module is overkill for just
a few lines of code.
The commit message answers your second and third questions.
- Eric
next prev parent reply other threads:[~2022-07-19 4:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-16 6:29 [PATCH v2 0/3] crypto: lib - create utils module Eric Biggers
2022-07-16 6:29 ` [PATCH v2 1/3] crypto: lib - create utils module and move __crypto_memneq into it Eric Biggers
2022-07-16 6:29 ` [PATCH v2 2/3] crypto: lib - move __crypto_xor into utils Eric Biggers
2022-07-16 6:29 ` [PATCH v2 3/3] crypto: lib - move crypto_simd_disabled_for_test " Eric Biggers
2022-07-16 18:32 ` Jason A. Donenfeld
2022-07-19 4:34 ` Eric Biggers [this message]
2022-07-21 7:01 ` Eric Biggers
2022-07-21 7:36 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtY0T4qASnYOIjIW@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=Jason@zx2c4.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).