From: Phil Auld <pauld@redhat.com>
To: Valentin Schneider <vschneid@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v3 1/2] cpuhp: make target_store() a nop when target == state
Date: Tue, 19 Jul 2022 11:03:10 -0400 [thread overview]
Message-ID: <YtbHrmDem1v++dBL@lorien.usersys.redhat.com> (raw)
In-Reply-To: <xhsmhk0896ujo.mognet@vschneid.remote.csb>
On Tue, Jul 19, 2022 at 03:34:03PM +0100 Valentin Schneider wrote:
> On 11/07/22 17:16, Phil Auld wrote:
> > writing the current state back in hotplug/target calls cpu_down()
> > which will set cpu dying even when it isn't and then nothing will
> > ever clear it. A stress test that reads values and writes them back
> > for all cpu device files in sysfs will trigger the BUG() in
> > select_fallback_rq once all cpus are marked as dying.
> >
> > kernel/cpu.c::target_store()
> > ...
> > if (st->state < target)
> > ret = cpu_up(dev->id, target);
> > else
> > ret = cpu_down(dev->id, target);
> >
> > cpu_down() -> cpu_set_state()
> > bool bringup = st->state < target;
> > ...
> > if (cpu_dying(cpu) != !bringup)
> > set_cpu_dying(cpu, !bringup);
> >
> > Fix this by letting state==target fall through in the target_store()
> > conditional. Also make sure st->target == target in that case.
> >
> > Signed-off-by: Phil Auld <pauld@redhat.com>
>
> One nit below, otherwise:
> Reviewed-by: Valentin Schneider <vschneid@redhat.com>
>
Thanks!
> > ---
> > kernel/cpu.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/kernel/cpu.c b/kernel/cpu.c
> > index bbad5e375d3b..305694a2ca26 100644
> > --- a/kernel/cpu.c
> > +++ b/kernel/cpu.c
> > @@ -2326,8 +2326,10 @@ static ssize_t target_store(struct device *dev, struct device_attribute *attr,
> >
> > if (st->state < target)
> > ret = cpu_up(dev->id, target);
> > - else
> > + else if (st->state > target)
> > ret = cpu_down(dev->id, target);
> > + else if (st->target != target)
>
> Should we make this:
>
> else if (WARN(st->target != target))
>
If you think that's important I can make it a WARN, sure.
I'll try to remember to keep your Reviewed-bys this time if that's okay.
Cheers,
Phil
> > + st->target = target;
> > out:
> > unlock_device_hotplug();
> > return ret ? ret : count;
> > --
> > 2.31.1
>
--
next prev parent reply other threads:[~2022-07-19 15:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 21:16 [PATCH v3 0/2] cpuhp: fix some st->target issues Phil Auld
2022-07-11 21:16 ` [PATCH v3 1/2] cpuhp: make target_store() a nop when target == state Phil Auld
2022-07-19 14:34 ` Valentin Schneider
2022-07-19 15:03 ` Phil Auld [this message]
2022-07-11 21:16 ` [PATCH v3 2/2] cpuhp: Set cpuhp target for boot cpu Phil Auld
2022-07-19 14:34 ` Valentin Schneider
2022-08-10 14:45 ` [PATCH v3 0/2] cpuhp: fix some st->target issues Phil Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtbHrmDem1v++dBL@lorien.usersys.redhat.com \
--to=pauld@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).