From: Mark Brown <broonie@kernel.org>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: avifishman70@gmail.com, tali.perry1@gmail.com, joel@jms.id.au,
venture@google.com, yuenn@google.com, benjaminfair@google.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
openbmc@lists.ozlabs.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 0/2] spi: npcm-pspi: add Arbel NPCM8XX and full duplex support
Date: Thu, 21 Jul 2022 13:19:23 +0100 [thread overview]
Message-ID: <YtlES7MX6nJr8l+L@sirena.org.uk> (raw)
In-Reply-To: <20220721101556.118568-1-tmaimon77@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 817 bytes --]
On Thu, Jul 21, 2022 at 01:15:54PM +0300, Tomer Maimon wrote:
> Tomer Maimon (2):
> spi: npcm-pspi: add full duplex support
> dt-binding: spi: npcm-pspi: Add npcm845 compatible
It is not obvious why these are a series, they appear to be entirely
orthogonal. If there's no relationship between patches it's generally
better to send them separately, that way problems with one patch won't
hold up unrelated patches and reviewers aren't left wondering about why
things are grouped.
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-07-21 12:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 10:15 [PATCH v1 0/2] spi: npcm-pspi: add Arbel NPCM8XX and full duplex support Tomer Maimon
2022-07-21 10:15 ` [PATCH v1 1/2] spi: npcm-pspi: add " Tomer Maimon
2022-07-21 13:46 ` Mark Brown
2022-07-24 9:35 ` Tomer Maimon
2022-07-25 12:15 ` Mark Brown
2022-07-21 10:15 ` [PATCH v1 2/2] dt-binding: spi: npcm-pspi: Add npcm845 compatible Tomer Maimon
2022-07-21 12:09 ` Mark Brown
2022-07-21 14:57 ` Tomer Maimon
2022-07-21 12:19 ` Mark Brown [this message]
2022-07-21 14:35 ` [PATCH v1 0/2] spi: npcm-pspi: add Arbel NPCM8XX and full duplex support Tomer Maimon
-- strict thread matches above, loose matches on Subject: below --
2022-07-21 10:15 Tomer Maimon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtlES7MX6nJr8l+L@sirena.org.uk \
--to=broonie@kernel.org \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).