From: Greg KH <gregkh@linuxfoundation.org>
To: Alix Dixon <notdixon.alix@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: android: binder: Fixed coding style issue
Date: Fri, 5 Aug 2022 15:33:46 +0200 [thread overview]
Message-ID: <Yu0cOiT3qKK/osGd@kroah.com> (raw)
In-Reply-To: <20220805130611.59289-1-notdixon.alix@gmail.com>
On Fri, Aug 05, 2022 at 02:06:11PM +0100, Alix Dixon wrote:
> Fixed issue with comments on multiple lines not being aligned correctly + multiline comments not being on multiple lines
The irony of a changelog about not wrapping lines properly having an
inproper wrapped line is not lost on me :)
>
> Signed-off-by: Alix Dixon <notdixon.alix@gmail.com>
Any reason you didn't cc: all of the proper people that
scripts/get_maintainer.pl told you to cc? This driver does have very
active maintainers.
> ---
> drivers/android/binder.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index c964d7c8c..5a6da6765 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -5289,8 +5289,10 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> unsigned int size = _IOC_SIZE(cmd);
> void __user *ubuf = (void __user *)arg;
>
> - /*pr_info("binder_ioctl: %d:%d %x %lx\n",
> - proc->pid, current->pid, cmd, arg);*/
> + /*
> + * pr_info("binder_ioctl: %d:%d %x %lx\n",
> + * proc->pid, current->pid, cmd, arg);
> + */
There's nothing wrong with the original code here.
Please fix up and resend.
thanks,
greg k-h
prev parent reply other threads:[~2022-08-05 13:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 13:06 [PATCH] drivers: android: binder: Fixed coding style issue Alix Dixon
2022-08-05 13:33 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yu0cOiT3qKK/osGd@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=notdixon.alix@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).