From: Peter Xu <peterx@redhat.com>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: David Hildenbrand <david@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Muchun Song <songmuchun@bytedance.com>,
Peter Feiner <pfeiner@google.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v1 1/2] mm/hugetlb: fix hugetlb not supporting write-notify
Date: Fri, 5 Aug 2022 19:13:47 -0400 [thread overview]
Message-ID: <Yu2kK6s8m8NLDjuV@xz-m1.local> (raw)
In-Reply-To: <Yu2CI4wGLHCjMSWm@monkey>
On Fri, Aug 05, 2022 at 01:48:35PM -0700, Mike Kravetz wrote:
> On 08/05/22 20:57, David Hildenbrand wrote:
> > On 05.08.22 20:33, Mike Kravetz wrote:
> > > On 08/05/22 20:25, David Hildenbrand wrote:
> > >> On 05.08.22 20:23, Mike Kravetz wrote:
> > >>> On 08/05/22 14:14, Peter Xu wrote:
> > >>>> On Fri, Aug 05, 2022 at 01:03:28PM +0200, David Hildenbrand wrote:
> > >>>>> diff --git a/mm/mmap.c b/mm/mmap.c
> > >>>>> index 61e6135c54ef..462a6b0344ac 100644
> > >>>>> --- a/mm/mmap.c
> > >>>>> +++ b/mm/mmap.c
> > >>>>> @@ -1683,6 +1683,13 @@ int vma_wants_writenotify(struct vm_area_struct *vma, pgprot_t vm_page_prot)
> > >>>>> if ((vm_flags & (VM_WRITE|VM_SHARED)) != ((VM_WRITE|VM_SHARED)))
> > >>>>> return 0;
> > >>>>>
> > >>>>> + /*
> > >>>>> + * Hugetlb does not require/support writenotify; especially, it does not
> > >>>>> + * support softdirty tracking.
> > >>>>> + */
> > >>>>> + if (is_vm_hugetlb_page(vma))
> > >>>>> + return 0;
> > >>>>
> > >>>> I'm kind of confused here.. you seems to be fixing up soft-dirty for
> > >>>> hugetlb but here it's explicitly forbidden.
> > >>>>
> > >>>> Could you explain a bit more on why this patch is needed if (assume
> > >>>> there'll be a working) patch 2 being provided?
> > >>>>
> > >>>
> > >>> No comments on the patch, but ...
> > >>>
> > >>> Since it required little thought, I ran the test program on next-20220802 and
> > >>> was surprised that the issue did not recreate. Even added a simple printk
> > >>> to make sure we were getting into vma_wants_writenotify with a hugetlb vma.
> > >>> We were.
> > >>
> > >>
> > >> ... does your config have CONFIG_MEM_SOFT_DIRTY enabled?
> > >>
> > >
> > > No, Duh!
> > >
> > > FYI - Some time back, I started looking at adding soft dirty support for
> > > hugetlb mappings. I did not finish that work. But, I seem to recall
> > > places where code was operating on hugetlb mappings when perhaps it should
> > > not.
> > >
> > > Perhaps, it would also be good to just disable soft dirty for hugetlb at
> > > the source?
> >
> > I thought about that as well. But I came to the conclusion that without
> > patch #2, hugetlb VMAs cannot possibly support write-notify, so there is
> > no need to bother in vma_wants_writenotify() at all.
> >
> > The "root" would be places where we clear VM_SOFTDIRTY. That should only
> > be fs/proc/task_mmu.c:clear_refs_write() IIRC.
> >
> > So I don't particularly care, I consider this patch a bit cleaner and
> > more generic, but I can adjust clear_refs_write() instead of there is a
> > preference.
> >
>
> After a closer look, I agree that this may be the simplest/cleanest way to
> proceed. I was going to suggest that you note hugetlb does not support
> softdirty, but see you did in the comment.
>
> Acked-by: Mike Kravetz <mike.kravetz@oracle.com>
Filtering out hugetlbfs in vma_wants_writenotify() is still a bit hard to
follow to me, since it's not clear why hugetlbfs never wants writenotify.
If it's only about soft-dirty, we could have added the hugetlbfs check into
vma_soft_dirty_enabled(), then I think it'll achieve the same thing and
much clearer - with the soft-dirty check constantly returning false for it,
hugetlbfs shared vmas should have vma_wants_writenotify() naturally return
0 already.
For the long term - shouldn't we just enable soft-dirty for hugetlbfs? I
remember Mike used to have that in todo. Since we've got patch 2 already,
I feel like that's really much close (is the only missing piece the clear
refs write part? or maybe some more that I didn't notice).
Then patch 1 (or IMHO equivalant check in vma_soft_dirty_enabled(), but
maybe in stable trees we don't have vma_soft_dirty_enabled then it's
exactly patch 1) can be a stable-only backport just to avoid the bug from
triggering.
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2022-08-05 23:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 11:03 [PATCH v1 0/2] mm/hugetlb: fix write-fault handling for shared mappings David Hildenbrand
2022-08-05 11:03 ` [PATCH v1 1/2] mm/hugetlb: fix hugetlb not supporting write-notify David Hildenbrand
2022-08-05 18:14 ` Peter Xu
2022-08-05 18:22 ` David Hildenbrand
2022-08-05 18:23 ` Mike Kravetz
2022-08-05 18:25 ` David Hildenbrand
2022-08-05 18:33 ` Mike Kravetz
2022-08-05 18:57 ` David Hildenbrand
2022-08-05 20:48 ` Mike Kravetz
2022-08-05 23:13 ` Peter Xu [this message]
2022-08-05 23:33 ` Mike Kravetz
2022-08-08 16:10 ` Peter Xu
2022-08-08 16:36 ` David Hildenbrand
2022-08-08 19:28 ` Peter Xu
2022-08-10 9:29 ` David Hildenbrand
2022-08-05 11:03 ` [PATCH v1 2/2] mm/hugetlb: support write-faults in shared mappings David Hildenbrand
2022-08-05 18:12 ` Peter Xu
2022-08-05 18:20 ` David Hildenbrand
2022-08-08 16:05 ` Peter Xu
2022-08-08 16:25 ` David Hildenbrand
2022-08-08 20:21 ` Peter Xu
2022-08-08 22:08 ` Peter Xu
2022-08-10 9:37 ` David Hildenbrand
2022-08-10 9:45 ` David Hildenbrand
2022-08-10 19:29 ` Peter Xu
2022-08-10 19:40 ` David Hildenbrand
2022-08-10 19:52 ` Peter Xu
2022-08-10 23:55 ` Mike Kravetz
2022-08-11 8:48 ` David Hildenbrand
2022-08-05 23:08 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yu2kK6s8m8NLDjuV@xz-m1.local \
--to=peterx@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=pfeiner@google.com \
--cc=songmuchun@bytedance.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).