From: Christoph Hellwig <hch@infradead.org>
To: Chao Gao <chao.gao@intel.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
hch@infradead.org, m.szyprowski@samsung.com,
robin.murphy@arm.com, konrad.wilk@oracle.com, jxgao@google.com
Subject: Re: [PATCH] swiotlb: avoid potential left shift overflow
Date: Sat, 6 Aug 2022 01:26:50 -0700 [thread overview]
Message-ID: <Yu4lyhNFXRJjNc6Y@infradead.org> (raw)
In-Reply-To: <20220805114438.102085-1-chao.gao@intel.com>
On Fri, Aug 05, 2022 at 07:44:38PM +0800, Chao Gao wrote:
> The second operand passed to slot_addr() is declared as int or unsigned int
> in all call sites. The left-shift to get the offset of a slot can overflow
> if swiotlb size is larger than 4G.
>
> Fixes: 26a7e094783d ("swiotlb: refactor swiotlb_tbl_map_single")
> Signed-off-by: Chao Gao <chao.gao@intel.com>
Can you just convert it to an inline function? That will take care
of the typing in a much cleaner way than a cast.
prev parent reply other threads:[~2022-08-06 8:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 11:44 [PATCH] swiotlb: avoid potential left shift overflow Chao Gao
2022-08-06 8:26 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yu4lyhNFXRJjNc6Y@infradead.org \
--to=hch@infradead.org \
--cc=chao.gao@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jxgao@google.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).