From: Tejun Heo <tj@kernel.org>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: cgroups@vger.kernel.org, Zefan Li <lizefan.x@bytedance.com>,
Christian Brauner <brauner@kernel.org>,
linux-kernel@vger.kernel.org, kernel-team@fb.com,
Namhyung Kim <namhyung@kernel.org>,
Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH v2 cgroup/for-5.20] cgroup: Replace cgroup->ancestor_ids[] with ->ancestors[]
Date: Fri, 29 Jul 2022 13:02:10 -1000 [thread overview]
Message-ID: <YuRm8s/CFmGKYPc1@slm.duckdns.org> (raw)
In-Reply-To: <YuRiQc35guAWcbjt@blackbook>
On Sat, Jul 30, 2022 at 12:42:09AM +0200, Michal Koutný wrote:
> On Fri, Jul 29, 2022 at 10:58:22AM -1000, Tejun Heo <tj@kernel.org> wrote:
> > @@ -520,8 +520,8 @@ struct cgroup_root {
> > /* The root cgroup. Root is destroyed on its release. */
> > struct cgroup cgrp;
> >
> > - /* for cgrp->ancestor_ids[0] */
> > - u64 cgrp_ancestor_id_storage;
> > + /* for cgrp->ancestors[0] */
> > + u64 cgrp_ancestor_storage;
>
> Just noticed, this member is (and was AFAICS) superfluous.
I should have changed the type to struct cgroup * but that's the space into
which cgroup_root->cgrp->ancestors[] stretch into.
Thanks.
--
tejun
next prev parent reply other threads:[~2022-07-29 23:02 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 19:05 [PATCH cgroup/for-5.20] cgroup: Replace cgroup->ancestor_ids[] with ->ancestors[] Tejun Heo
2022-07-29 20:30 ` Namhyung Kim
2022-07-29 20:58 ` [PATCH v2 " Tejun Heo
2022-07-29 22:42 ` Michal Koutný
2022-07-29 23:02 ` Tejun Heo [this message]
2022-07-29 23:10 ` [PATCH v3 " Tejun Heo
2022-08-15 21:17 ` Tejun Heo
2022-09-22 4:05 ` Namhyung Kim
2022-09-22 4:14 ` [PATCH] perf stat: Support old kernels for bperf cgroup counting Namhyung Kim
2022-09-24 3:22 ` Tejun Heo
2022-09-30 20:30 ` Namhyung Kim
2022-09-30 21:43 ` Jiri Olsa
2022-09-30 21:56 ` Namhyung Kim
2022-09-30 22:00 ` Arnaldo Carvalho de Melo
2022-09-30 22:11 ` Namhyung Kim
2022-10-01 13:57 ` Jiri Olsa
2022-09-30 22:48 ` Andrii Nakryiko
2022-10-01 2:31 ` Namhyung Kim
2022-10-05 22:36 ` Andrii Nakryiko
2022-10-01 13:58 ` Jiri Olsa
2022-10-10 23:59 ` Tejun Heo
2022-10-11 5:24 ` Namhyung Kim
2022-10-11 5:28 ` [PATCH v2] " Namhyung Kim
2022-10-11 16:53 ` Tejun Heo
2022-10-14 13:27 ` Arnaldo Carvalho de Melo
2022-10-14 13:30 ` Arnaldo Carvalho de Melo
2022-10-14 16:40 ` Tejun Heo
2022-10-14 17:10 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuRm8s/CFmGKYPc1@slm.duckdns.org \
--to=tj@kernel.org \
--cc=brauner@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=mkoutny@suse.com \
--cc=namhyung@kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).