From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9B27C19F2C for ; Tue, 2 Aug 2022 14:01:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237037AbiHBOBn (ORCPT ); Tue, 2 Aug 2022 10:01:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234666AbiHBOBl (ORCPT ); Tue, 2 Aug 2022 10:01:41 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2933E1C107 for ; Tue, 2 Aug 2022 07:01:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659448899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LUHv4x5a6YZb94507hyxXVCHu0MZW82loqntFPHXbN4=; b=fVs70xwm7BrXW8HK86cSkURsaHKNgGZArxJ62vlV3yt42F/GeqVWasICwr3bQmFNm6eeJE cnFXLGvVzIi1gGz/WKiel8MaMmnpfsg7B1PTtWN2uP5ncPxNl5zoFbjX5JVeeGVmSCrXj/ w7U3zNJ8G9049SxhoN331cSNEL1RdJ8= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-213-LPxgT18nOR-lsh_asIxZIw-1; Tue, 02 Aug 2022 10:01:35 -0400 X-MC-Unique: LPxgT18nOR-lsh_asIxZIw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DE4841C0512A; Tue, 2 Aug 2022 14:01:34 +0000 (UTC) Received: from sparkplug.usersys.redhat.com (unknown [10.40.192.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BD895141510F; Tue, 2 Aug 2022 14:01:32 +0000 (UTC) Date: Tue, 2 Aug 2022 16:01:30 +0200 From: Artem Savkov To: Jiri Olsa Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrea Arcangeli , Daniel Vacek , Song Liu , Daniel Xu Subject: Re: [PATCH bpf-next v2 2/3] bpf: export crash_kexec() as destructive kfunc Message-ID: References: <20220802091030.3742334-1-asavkov@redhat.com> <20220802091030.3742334-3-asavkov@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 02, 2022 at 12:46:42PM +0200, Jiri Olsa wrote: > On Tue, Aug 02, 2022 at 11:10:29AM +0200, Artem Savkov wrote: > > +static int __init crash_kfunc_init(void) > > +{ > > + register_btf_kfunc_id_set(BPF_PROG_TYPE_TRACING, &kexec_kfunc_set); > > + return 0; > > should we do 'return register_btf_kfunc_id_set(...' in here? Maybe, but as far as I can tell the return value for init calls does absolutely nothing except for showing up in a debug message. So I don't think it will be worth a respin, but if there is one anyway I'll change this. -- Artem