From: Sean Christopherson <seanjc@google.com>
To: Like Xu <like.xu.linux@gmail.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 1/3] KVM: x86: Refresh PMU after writes to MSR_IA32_PERF_CAPABILITIES
Date: Wed, 3 Aug 2022 14:37:10 +0000 [thread overview]
Message-ID: <YuqIFjlk5iDtVnRm@google.com> (raw)
In-Reply-To: <cb631fe5-103d-30f5-d800-4748f4ea41fa@gmail.com>
On Wed, Aug 03, 2022, Like Xu wrote:
> On 28/7/2022 7:34 am, Sean Christopherson wrote:
> > Refresh the PMU if userspace modifies MSR_IA32_PERF_CAPABILITIES. KVM
> > consumes the vCPU's PERF_CAPABILITIES when enumerating PEBS support, but
> > relies on CPUID updates to refresh the PMU. I.e. KVM will do the wrong
> > thing if userspace stuffs PERF_CAPABILITIES _after_ setting guest CPUID.
> >
> > Opportunistically fix a curly-brace indentation.
> >
> > Fixes: c59a1f106f5c ("KVM: x86/pmu: Add IA32_PEBS_ENABLE MSR emulation for extended PEBS")
>
> Shouldn't it be: Fixes: 27461da31089 ("KVM: x86/pmu: Support full width counting") ?
Strictly speaking, I don't think so? fw_writes_is_enabled() returns false if
guest CPUID doesn't have X86_FEATURE_PDCM, and AFAICT there are no other side
effects that are handled by intel_pmu_refresh().
> Now, all the dots have been connected. As punishment, I'd like to cook this
> patch set more with trackable tests so that you have more time for other
> things that are not housekeeping.
Let me post v2, I've already done all the work and testing. If there's more to
be done, we can figure out next steps from there.
next prev parent reply other threads:[~2022-08-03 14:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 23:34 [PATCH 0/3] KVM: x86: Intel PERF_CAPABILITIES fix and cleanups Sean Christopherson
2022-07-27 23:34 ` [PATCH 1/3] KVM: x86: Refresh PMU after writes to MSR_IA32_PERF_CAPABILITIES Sean Christopherson
2022-07-28 12:02 ` Like Xu
2022-07-28 15:27 ` Sean Christopherson
2022-07-29 9:33 ` Like Xu
2022-07-29 13:51 ` Sean Christopherson
2022-08-03 12:29 ` Like Xu
2022-08-03 14:37 ` Sean Christopherson [this message]
2022-08-03 18:47 ` Sean Christopherson
2022-07-27 23:34 ` [PATCH 2/3] KVM: VMX: Use proper type-safe functions for vCPU => LBRs helpers Sean Christopherson
2022-07-29 8:39 ` Like Xu
2022-07-29 16:08 ` Sean Christopherson
2022-07-27 23:34 ` [PATCH 3/3] KVM: VMX: Adjust number of LBR records for PERF_CAPABILITIES at refresh Sean Christopherson
2022-07-29 10:10 ` Like Xu
2022-07-29 17:28 ` Sean Christopherson
2022-08-02 12:04 ` Like Xu
2022-08-02 14:57 ` Sean Christopherson
2022-08-10 13:24 ` [PATCH 0/3] KVM: x86: Intel PERF_CAPABILITIES fix and cleanups Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuqIFjlk5iDtVnRm@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=like.xu.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).