From: Ingo Molnar <mingo@kernel.org>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Liu Song <liusong@linux.alibaba.com>,
mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
vschneid@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/debug: avoid executing show_state and causing rcu stall warning
Date: Wed, 3 Aug 2022 19:14:52 +0200 [thread overview]
Message-ID: <YuqtDA4NY/8Z22aK@gmail.com> (raw)
In-Reply-To: <20220803140653.GD2125313@paulmck-ThinkPad-P17-Gen-1>
* Paul E. McKenney <paulmck@kernel.org> wrote:
> There is an rcu_sysrq_start() and rcu_sysrq_end() to suppress this.
> These are invoked by __handle_sysrq(). The value of
> rcu_cpu_stall_suppress should be non-zero during the sysrq execution, and
> this should prevent RCU CPU stall warnings from being printed.
>
> That said, the code currently does not support overlapping calls to the
> various functions that suppress RCU CPU stall warnings. Except that the
> only other use in current mainline is rcu_panic(), which never
> unsuppresses.
>
> So could you please check the value of rcu_cpu_stall_suppress? Just in
> case some other form of suppression was added somewhere that I missed?
So instead of supressing the (justified!) RCU stall messages, I'd much
rather we apply only the minimal locking necessary for this debug printout.
That should also solve the stall warnings as a side effect.
Thanks,
Ingo
next prev parent reply other threads:[~2022-08-03 17:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 1:18 [PATCH] sched/debug: avoid executing show_state and causing rcu stall warning Liu Song
2022-08-03 8:39 ` Ingo Molnar
2022-08-03 8:58 ` Liu Song
2022-08-03 9:10 ` Ingo Molnar
2022-08-03 9:25 ` Liu Song
2022-08-03 12:42 ` Steven Rostedt
2022-08-03 14:06 ` Paul E. McKenney
2022-08-03 17:14 ` Ingo Molnar [this message]
2022-08-03 17:42 ` Paul E. McKenney
2022-08-03 17:13 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuqtDA4NY/8Z22aK@gmail.com \
--to=mingo@kernel.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liusong@linux.alibaba.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).