From: Mark Brown <broonie@kernel.org>
To: "chunxu.li" <chunxu.li@mediatek.com>
Cc: pierre-louis.bossart@linux.intel.com,
peter.ujfalusi@linux.intel.com, lgirdwood@gmail.com,
angelogioacchino.delregno@collabora.com, daniel.baluta@nxp.com,
matthias.bgg@gmail.com, yc.hung@mediatek.com,
tinghan.shen@mediatek.com, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org,
sound-open-firmware@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
project_global_chrome_upstream_group@mediatek.com
Subject: Re: [PATCH 2/2] ASoC: SOF: mediatek: Add .of_machine_select field for mt8186
Date: Thu, 4 Aug 2022 14:33:02 +0100 [thread overview]
Message-ID: <YuvKjn3cW5im2Yw9@sirena.org.uk> (raw)
In-Reply-To: <46f972f41a8c1bbfc2bfa42c431308f6b5fe2234.camel@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 946 bytes --]
On Thu, Aug 04, 2022 at 09:21:37PM +0800, chunxu.li wrote:
> On Thu, 2022-08-04 at 13:41 +0100, Mark Brown wrote:
> > On Thu, Aug 04, 2022 at 05:13:59PM +0800, Chunxu Li wrote:
> > > + .board = "mediatek,mt8186",
> > > + .sof_tplg_filename = "sof-mt8186.tplg",
> > The mediatek,mt8186 compatible looks like a SoC compatible not a
> > board
> > compatible...
> Our dts config as below:
> kingler board:
> compatible = "google,corsola", "google,kingler", "mediatek,mt8186";
> krabby board:
> compatible = "google,corsola", "google,krabby", "mediatek,mt8186";
So the SoC is listed as a fallback for the board and things work out
fine.
> Which of the two approaches do you prefer?
I think it would be clearer to keep what's being matched the same but
rename the .board field to be .compatible, or possibly .system_compatible
or something if it's unclear what's being matched. That'd be more
normal for specifying a compatible string anyway.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-08-04 13:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220804091359.31449-1-chunxu.li@mediatek.com>
2022-08-04 9:13 ` [PATCH 1/2] ASoC: SOF: Introduce optional callback of_machine_select Chunxu Li
2022-08-04 13:17 ` Mark Brown
[not found] ` <644d24503899e6ed8b6a7321979e11e46577a610.camel@mediatek.com>
2022-08-04 14:59 ` Mark Brown
2022-08-04 9:13 ` [PATCH 2/2] ASoC: SOF: mediatek: Add .of_machine_select field for mt8186 Chunxu Li
2022-08-04 12:41 ` Mark Brown
[not found] ` <46f972f41a8c1bbfc2bfa42c431308f6b5fe2234.camel@mediatek.com>
2022-08-04 13:33 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuvKjn3cW5im2Yw9@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunxu.li@mediatek.com \
--cc=daniel.baluta@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=project_global_chrome_upstream_group@mediatek.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tinghan.shen@mediatek.com \
--cc=yc.hung@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).