On Thu, Aug 04, 2022 at 10:36:07PM +0800, chunxu.li wrote: > Thanks for you advice, I'll remove the callback function, and directly > call sof_of_machine_select() in sof_machine_check() as following. > > int sof_machine_check(struct snd_sof_dev *sdev) > { > } > > > + of_mach = sof_of_machine_select(sdev); > + if (of_mach) { > + sof_pdata->of_machine = of_mach; > + return 0; > + } Looks good.