From: Nate Yocom <nate@yocom.org>
To: Bastien Nocera <hadess@hadess.net>
Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] Input: joystick: xpad: Add X-Box Adaptive Controller support
Date: Wed, 17 Aug 2022 10:36:15 -0700 [thread overview]
Message-ID: <Yv0nD36XqUvoGUHZ@ghaven-kernel> (raw)
In-Reply-To: <c7c1373b84a297d2745c4fb98ad2ecf26e67f0d5.camel@hadess.net>
On Wed, Aug 17, 2022 at 12:37:02PM +0200, Bastien Nocera wrote:
> On Sat, 2022-08-13 at 11:53 -0700, Nate Yocom wrote:
> > Adds correct VID/PID for this XTYPE_XBOXONE compatible controller to
> > xpad_device[] table.
> >
> > Signed-off-by: Nate Yocom <nate@yocom.org>
>
> Have you tested the device in Bluetooth mode? My controller's battery
> is still charging.
I have tried, but haven't been successful in getting it connected with,
or without my changes (i.e. no change), so was focused on cabled support
first.
> Tested-by: Bastien Nocera <hadess@hadess.net>
Thanks!
>
> > ---
> > drivers/input/joystick/xpad.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/input/joystick/xpad.c
> > b/drivers/input/joystick/xpad.c
> > index 18190b529bca..c8b38bb73d34 100644
> > --- a/drivers/input/joystick/xpad.c
> > +++ b/drivers/input/joystick/xpad.c
> > @@ -131,6 +131,7 @@ static const struct xpad_device {
> > { 0x045e, 0x02e3, "Microsoft X-Box One Elite pad", 0,
> > XTYPE_XBOXONE },
> > { 0x045e, 0x02ea, "Microsoft X-Box One S pad", 0,
> > XTYPE_XBOXONE },
> > { 0x045e, 0x0719, "Xbox 360 Wireless Receiver",
> > MAP_DPAD_TO_BUTTONS, XTYPE_XBOX360W },
> > + { 0x045e, 0x0b0a, "Microsoft X-Box Adaptive Controller", 0,
> > XTYPE_XBOXONE },
> > { 0x045e, 0x0b12, "Microsoft Xbox Series S|X Controller",
> > MAP_SELECT_BUTTON, XTYPE_XBOXONE },
> > { 0x046d, 0xc21d, "Logitech Gamepad F310", 0, XTYPE_XBOX360
> > },
> > { 0x046d, 0xc21e, "Logitech Gamepad F510", 0, XTYPE_XBOX360
> > },
>
next prev parent reply other threads:[~2022-08-17 17:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-13 18:53 [PATCH v3 0/3] Input: joystick: xpad: Add X-Box Adaptive Controller support Nate Yocom
2022-08-13 18:53 ` [PATCH v3 1/3] " Nate Yocom
2022-08-17 10:37 ` Bastien Nocera
2022-08-17 17:36 ` Nate Yocom [this message]
2022-08-13 18:53 ` [PATCH v3 2/3] Input: joystick: xpad: Add X-Box Adaptive Controller Layer button Nate Yocom
2022-08-17 10:37 ` Bastien Nocera
2022-08-17 17:42 ` Nate Yocom
2022-08-24 15:36 ` Bastien Nocera
2022-08-25 22:21 ` Nate Yocom
2022-08-13 18:53 ` [PATCH v3 3/3] Input: joystick: xpad: Add X-Box Adaptive Controller XBox button Nate Yocom
2022-08-17 10:37 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv0nD36XqUvoGUHZ@ghaven-kernel \
--to=nate@yocom.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).