From: Borislav Petkov <bp@alien8.de>
To: Jia He <justin.he@arm.com>
Cc: Ard Biesheuvel <ardb@kernel.org>, Len Brown <lenb@kernel.org>,
James Morse <james.morse@arm.com>,
Tony Luck <tony.luck@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Richter <rric@kernel.org>,
Robert Moore <robert.moore@intel.com>,
Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
Yazen Ghannam <yazen.ghannam@amd.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-edac@vger.kernel.org, devel@acpica.org,
"Rafael J . Wysocki" <rafael@kernel.org>,
Shuai Xue <xueshuai@linux.alibaba.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
linux-efi@vger.kernel.org, toshi.kani@hpe.com, nd@arm.com
Subject: Re: [PATCH v2 2/7] EDAC/ghes: Add notifier to report ghes_edac mem error
Date: Thu, 18 Aug 2022 17:42:07 +0200 [thread overview]
Message-ID: <Yv5dzyiI1TPtAO5F@zn.tnic> (raw)
In-Reply-To: <20220817143458.335938-3-justin.he@arm.com>
On Wed, Aug 17, 2022 at 02:34:53PM +0000, Jia He wrote:
> Subject: Re: [PATCH v2 2/7] EDAC/ghes: Add notifier to report ghes_edac mem error
Subject: ...: Add a notifier for reporting memory errors.
> To modularize ghes_edac driver, any ghes_edac codes should not be invoked
s/modularize/make a proper module/
and replace that everywhere.
There's no such thing as "codes" - please try to write proper English.
> in ghes. Add a notifier of registering the ghes_edac_report_mem_error() to
> resolve the build dependency.
"Add a notifier for reporting memory errors."
When you say "to resolve the build dependency" it sounds like this is
some kind of a nuisance. But it isn't one - it is simply an improvement.
> The atomic notifier is used because
> ghes_proc_in_irq() can be in the irq context.
"Use an atomic notifier because calls sites like ghes_proc_in_irq() run
in interrupt context."
> Suggested-by: Borislav Petkov <bp@alien8.de>
> Signed-off-by: Jia He <justin.he@arm.com>
> ---
> drivers/acpi/apei/ghes.c | 16 +++++++++++++++-
> drivers/edac/ghes_edac.c | 19 +++++++++++++++++--
> include/acpi/ghes.h | 10 +++-------
> 3 files changed, 35 insertions(+), 10 deletions(-)
Patch itself looks ok.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-08-18 15:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 14:34 [PATCH v2 0/7] Modularize ghes_edac driver Jia He
2022-08-17 14:34 ` [PATCH v2 1/7] efi/cper: export several helpers for ghes edac to use Jia He
2022-08-18 14:38 ` Borislav Petkov
2022-08-17 14:34 ` [PATCH v2 2/7] EDAC/ghes: Add notifier to report ghes_edac mem error Jia He
2022-08-18 15:42 ` Borislav Petkov [this message]
2022-08-17 14:34 ` [PATCH v2 3/7] EDAC/ghes: Modularize ghes_edac driver to remove the dependency on ghes Jia He
2022-08-17 14:34 ` [PATCH v2 4/7] EDAC: Get chipset-specific edac drivers selected only when ghes_edac is not enabled Jia He
2022-08-18 23:56 ` Kani, Toshi
2022-08-19 1:57 ` Justin He
2022-08-17 14:34 ` [PATCH v2 5/7] EDAC/ghes: Prevent chipset-specific edac from loading after ghes_edac is registered Jia He
2022-08-19 1:29 ` Kani, Toshi
2022-08-19 10:34 ` Justin He
2022-08-19 17:48 ` Kani, Toshi
2022-08-19 18:29 ` Borislav Petkov
2022-08-19 18:46 ` Kani, Toshi
2022-08-19 18:50 ` Borislav Petkov
2022-08-19 18:53 ` Kani, Toshi
2022-08-19 19:31 ` Borislav Petkov
2022-08-19 19:37 ` Kani, Toshi
2022-08-19 18:57 ` Elliott, Robert (Servers)
2022-08-19 19:32 ` Borislav Petkov
2022-08-17 14:34 ` [PATCH v2 6/7] apei/ghes: Use unrcu_pointer for cmpxchg Jia He
2022-08-17 15:38 ` David Laight
2022-08-18 1:22 ` Justin He
2022-08-17 14:34 ` [PATCH v2 7/7] EDAC/igen6: Keep returned errno consistent when edac mc has been enabled Jia He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv5dzyiI1TPtAO5F@zn.tnic \
--to=bp@alien8.de \
--cc=ardb@kernel.org \
--cc=devel@acpica.org \
--cc=james.morse@arm.com \
--cc=jarkko@kernel.org \
--cc=justin.he@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nd@arm.com \
--cc=qiuxu.zhuo@intel.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=toshi.kani@hpe.com \
--cc=xueshuai@linux.alibaba.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).