From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89D3BC25B07 for ; Tue, 9 Aug 2022 15:15:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244723AbiHIPPf (ORCPT ); Tue, 9 Aug 2022 11:15:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230178AbiHIPPc (ORCPT ); Tue, 9 Aug 2022 11:15:32 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74BB22DD9; Tue, 9 Aug 2022 08:15:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2ABE9B815BD; Tue, 9 Aug 2022 15:15:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A06D0C433C1; Tue, 9 Aug 2022 15:15:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660058128; bh=8MAhwzgDKvXLL9NUx6d1QOtiUnfc6MIStnsocWXT2VI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W+DD2dAK1b6DDCTsNSoPyGT6HFX5nIWvp2F3jAvQiO0eZaqSJEwksndKiTpKaSmea VE47RREejiEbvKAN3ugdGJXZtA4vQjyex7n53vgm+lulBRFIxBQbivb+/gO/hk07vQ oGCW+Ubf8ZMd+RVWCQt3wRZZzI9e2Fs6OWqVa0f+K74PvdnrTx/mDywBJ0sRNo9Of2 ObxC6OD5doTjm2Da4dCzzHnZ3k0NcU8jagnCQEcOOgYy9WSNGbkrw+1Bsy87uB2fOT QHFo5Q+BUcSiI7ET8uHXoli4KjZiE5FSJzrtWekdQS69ksJTODOBIanCaCiou4x2Sg fscZvo1Gheepg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 680464035A; Tue, 9 Aug 2022 12:15:25 -0300 (-03) Date: Tue, 9 Aug 2022 12:15:25 -0300 From: Arnaldo Carvalho de Melo To: Daniel Borkmann Cc: Roberto Sassu , quentin@isovalent.com, ast@kernel.org, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, peterz@infradead.org, mingo@redhat.com, terrelln@fb.com, nathan@kernel.org, ndesaulniers@google.com, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org, Andres Freund , Jiri Olsa Subject: Re: [PATCH 4/4] build: Switch to new openssl API for test-libcrypto Message-ID: References: <20220719170555.2576993-1-roberto.sassu@huawei.com> <20220719170555.2576993-4-roberto.sassu@huawei.com> <5f867295-10d2-0085-d1dc-051f56e7136a@iogearbox.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Aug 08, 2022 at 03:33:34PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Aug 08, 2022 at 06:14:48PM +0200, Daniel Borkmann escreveu: > > Hi Arnaldo, > > > > On 7/19/22 7:05 PM, Roberto Sassu wrote: > > > Switch to new EVP API for detecting libcrypto, as Fedora 36 returns an > > > error when it encounters the deprecated function MD5_Init() and the others. > > > The error would be interpreted as missing libcrypto, while in reality it is > > > not. > > > > > > Signed-off-by: Roberto Sassu > > > > Given rest of the tooling fixes from Andres Freund went via perf tree and the > > below is perf related as well, I presume you'll pick this up, too? > > Sure. > > > [0] https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/log/?h=perf/core So I fixed up the first one, minor fuzzes, the second I had to fix conflicts with the patchset from Andres, ended up as below, will test build it then in my container kit. - Arnaldo commit bea955a0256e20cc18e87087e42f2a903b9a8b84 Author: Roberto Sassu Date: Tue Jul 19 19:05:53 2022 +0200 bpftool: Complete libbfd feature detection Commit 6e8ccb4f624a7 ("tools/bpf: properly account for libbfd variations") sets the linking flags depending on which flavor of the libbfd feature was detected. However, the flavors except libbfd cannot be detected, as they are not in the feature list. Complete the list of features to detect by adding libbfd-liberty and libbfd-liberty-z. Committer notes: Adjust conflict with with: 1e1613f64cc8a09d ("tools bpftool: Don't display disassembler-four-args feature test") 600b7b26c07a070d ("tools bpftool: Fix compilation error with new binutils") Fixes: 6e8ccb4f624a73c5 ("tools/bpf: properly account for libbfd variations") Signed-off-by: Roberto Sassu Cc: Alexei Starovoitov Cc: Andres Freund Cc: Andrii Nakryiko Cc: bpf@vger.kernel.org Cc: Daniel Borkmann Cc: Ingo Molnar Cc: John Fastabend Cc: KP Singh Cc: llvm@lists.linux.dev Cc: Martin KaFai Lau Cc: Nathan Chancellor Cc: Nick Desaulniers Cc: Nick Terrell Cc: Peter Zijlstra Cc: Quentin Monnet Cc: Song Liu Cc: Stanislav Fomichev Link: https://lore.kernel.org/r/20220719170555.2576993-2-roberto.sassu@huawei.com Signed-off-by: Arnaldo Carvalho de Melo diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile index 04d733e98bffbc08..9cc132277150c534 100644 --- a/tools/bpf/bpftool/Makefile +++ b/tools/bpf/bpftool/Makefile @@ -93,9 +93,11 @@ INSTALL ?= install RM ?= rm -f FEATURE_USER = .bpftool -FEATURE_TESTS = libbfd disassembler-four-args disassembler-init-styled libcap \ +FEATURE_TESTS = libbfd libbfd-liberty libbfd-liberty-z + disassembler-four-args disassembler-init-styled libcap \ clang-bpf-co-re -FEATURE_DISPLAY = libbfd libcap clang-bpf-co-re +FEATURE_DISPLAY = libbfd libbfd-liberty libbfd-liberty-z + libcap clang-bpf-co-re check_feat := 1 NON_CHECK_FEAT_TARGETS := clean uninstall doc doc-clean doc-install doc-uninstall