From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7551C25B0C for ; Thu, 11 Aug 2022 08:25:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234354AbiHKIZV (ORCPT ); Thu, 11 Aug 2022 04:25:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234073AbiHKIZT (ORCPT ); Thu, 11 Aug 2022 04:25:19 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 482BF13DDE for ; Thu, 11 Aug 2022 01:25:18 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EFA2437183; Thu, 11 Aug 2022 08:25:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1660206316; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kWKkak9v2ps7Zu0KlR7ytisVCQ4O5+05LJWZ1J59LX4=; b=DlgeBEuvQlAL+hiENKPkfbSkL/SfHqusREcp2ldByrXpOrKH6jP4w2hp3MCSffkjwCaOwq dUXScyGjT4oP5hUhqTkAboyQfMur5Pjhqte8cNZYRim0m9sfH/5GfDmZGCnP/e/OuuMsRy y0XWrCmq16RTbVx+nVzOx0Z8NaL3YVo= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CEB0213A9B; Thu, 11 Aug 2022 08:25:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id eys9MOy89GKLUQAAMHmgww (envelope-from ); Thu, 11 Aug 2022 08:25:16 +0000 Date: Thu, 11 Aug 2022 10:25:16 +0200 From: Michal Hocko To: Christoph Hellwig Cc: Baoquan He , Andrew Morton , John Donnelly , David Hildenbrand , linux-mm@kvack.org, LKML Subject: Re: [PATCH] dma/pool: do not complain if DMA pool is not allocated Message-ID: References: <20220811073840.GE13886@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220811073840.GE13886@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 11-08-22 09:38:40, Christoph Hellwig wrote: > On Tue, Aug 09, 2022 at 05:37:59PM +0200, Michal Hocko wrote: > > Here we go again. > > And just as last time I think this is the wrong thing to do. > IFF we actually need the pool and we can't allocate it we want this > warning. > > But order-10 seems very larger for the 31-bit ISA DMA zone, so we might > want to look into calculating the pool size based on the zone size > instead. No objection for a better size tuning from my side. I find it I suspect you will need __GFP_NOWARN to be used for downsizing the request size for all attempts anyway. -- Michal Hocko SUSE Labs