From: Herbert Xu <herbert@gondor.apana.org.au>
To: Robert Elliott <elliott@hpe.com>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, ardb@kernel.org,
toshi.kani@hpe.com
Subject: Re: [PATCH] crypto: tcrypt - remove mode=1000
Date: Tue, 16 Aug 2022 13:56:30 +0800 [thread overview]
Message-ID: <YvsxjuBlOw6g4I/c@gondor.apana.org.au> (raw)
In-Reply-To: <20220815042915.44547-1-elliott@hpe.com>
On Sun, Aug 14, 2022 at 11:29:15PM -0500, Robert Elliott wrote:
> The lists of algothms checked for existence by
> modprobe tcrypt mode=1000
> generates three bogus errors:
> modprobe tcrypt mode=1000
>
> console log:
> tcrypt: alg rot13 not found
> tcrypt: alg cts not found
> tcrypt: alg arc4 not found
>
> rot13 is not an algorithm in the crypto API or tested.
>
> cts is a wrapper, not a base algorithm.
>
> arc4 is named ecb(arc4), not arc4.
>
> Also, the list is missing numerous algorithms that are tested by
> other test modes:
> blake2b-512
> blake2s-256
> crct10dif
> xxhash64
> ghash
> cast5
> sm4
> ansi_prng
>
> Several of the algorithms are only available if
> CONFIG_CRYPTO_USER_API_ENABLE_OBSOLETE is enabled:
> arc4
> khazad
> seed
> tea, xtea, xeta
>
> Rather that fix that list, remove test mode=1000 entirely.
> It seems to have limited utility, and a web search shows no
> discussion of anybody using it.
>
> Suggested-by: Ard Biesheuvel <ardb@kernel.org>
> Signed-off-by: Robert Elliott <elliott@hpe.com>
> ---
> crypto/tcrypt.c | 28 ----------------------------
> 1 file changed, 28 deletions(-)
I think it would be better to use alg_test_descs as the source
list of get rid of check. But I never use this so unless someone
else complains I'm fine with removing it.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2022-08-16 8:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 4:29 [PATCH] crypto: tcrypt - remove mode=1000 Robert Elliott
2022-08-15 9:42 ` Ard Biesheuvel
2022-08-16 5:56 ` Herbert Xu [this message]
2022-08-26 11:03 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvsxjuBlOw6g4I/c@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ardb@kernel.org \
--cc=davem@davemloft.net \
--cc=elliott@hpe.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).