From: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Conor Dooley <mail@conchuod.ie>,
Daire McNamara <daire.mcnamara@microchip.com>,
Rob Herring <robh+dt@kernel.org>,
Albert Ou <aou@eecs.berkeley.edu>,
Palmer Dabbelt <palmer@dabbelt.com>,
devicetree@vger.kernel.org,
Greentime Hu <greentime.hu@sifive.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Conor Dooley <conor.dooley@microchip.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-riscv@lists.infradead.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/7] dt-bindings: PCI: fu740-pci: fix missing clock-names
Date: Tue, 23 Aug 2022 09:43:59 +0200 [thread overview]
Message-ID: <YwSFPwOkPIVC02fM@lpieralisi> (raw)
In-Reply-To: <20220822192032.GA283027-robh@kernel.org>
On Mon, Aug 22, 2022 at 02:20:32PM -0500, Rob Herring wrote:
> On Sat, 20 Aug 2022 00:14:10 +0100, Conor Dooley wrote:
> > From: Conor Dooley <conor.dooley@microchip.com>
> >
> > The commit b92225b034c0 ("dt-bindings: PCI: designware: Fix
> > 'unevaluatedProperties' warnings") removed the clock-names property as
> > a requirement and from the example as it triggered unevaluatedProperty
> > warnings. dtbs_check was not able to pick up on this at the time, but
> > now can:
> >
> > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dtb: pcie@e00000000: Unevaluated properties are not allowed ('clock-names' was unexpected)
> > From schema: linux/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml
> >
> > The property was already in use by the FU740 DTS and the clock must be
> > enabled. The Linux and FreeBSD drivers require the property to enable
> > the clocks correctly Re-add the property and its "clocks" dependency,
> > while making it required.
> >
> > Fixes: b92225b034c0 ("dt-bindings: PCI: designware: Fix 'unevaluatedProperties' warnings")
> > Fixes: 43cea116be0b ("dt-bindings: PCI: Add SiFive FU740 PCIe host controller")
> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> > ---
> > v2022.08 of dt-schema is required.
> > ---
> > .../devicetree/bindings/pci/sifive,fu740-pcie.yaml | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Should I pick these bindings updates up ?
Lorenzo
next prev parent reply other threads:[~2022-08-23 7:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 23:14 [PATCH v3 0/7] Fix RISC-V/PCI dt-schema issues with dt-schema v2022.08 Conor Dooley
2022-08-19 23:14 ` [PATCH v3 1/7] dt-bindings: PCI: fu740-pci: fix missing clock-names Conor Dooley
2022-08-22 19:20 ` Rob Herring
2022-08-23 7:43 ` Lorenzo Pieralisi [this message]
2022-08-23 20:21 ` Conor.Dooley
2022-08-19 23:14 ` [PATCH v3 2/7] dt-bindings: PCI: microchip,pcie-host: fix missing clocks properties Conor Dooley
2022-08-22 19:21 ` Rob Herring
2022-08-19 23:14 ` [PATCH v3 3/7] dt-bindings: PCI: microchip,pcie-host: fix missing dma-ranges Conor Dooley
2022-08-22 19:22 ` Rob Herring
2022-08-19 23:14 ` [PATCH v3 4/7] riscv: dts: microchip: mpfs: fix incorrect pcie child node name Conor Dooley
2022-08-19 23:14 ` [PATCH v3 5/7] riscv: dts: microchip: mpfs: remove ti,fifo-depth property Conor Dooley
2022-08-19 23:14 ` [PATCH v3 6/7] riscv: dts: microchip: mpfs: remove bogus card-detect-delay Conor Dooley
2022-08-19 23:14 ` [PATCH v3 7/7] riscv: dts: microchip: mpfs: remove pci axi address translation property Conor Dooley
2022-08-24 11:40 ` (subset) [PATCH v3 0/7] Fix RISC-V/PCI dt-schema issues with dt-schema v2022.08 Lorenzo Pieralisi
2022-08-24 16:19 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwSFPwOkPIVC02fM@lpieralisi \
--to=lpieralisi@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=bhelgaas@google.com \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=greentime.hu@sifive.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mail@conchuod.ie \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).