From: Peter Zijlstra <peterz@infradead.org>
To: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: acme@kernel.org, alexander.shishkin@linux.intel.com,
jolsa@redhat.com, namhyung@kernel.org, songliubraving@fb.com,
eranian@google.com, alexey.budankov@linux.intel.com,
ak@linux.intel.com, mark.rutland@arm.com, megha.dey@intel.com,
frederic@kernel.org, maddy@linux.ibm.com, irogers@google.com,
kim.phillips@amd.com, linux-kernel@vger.kernel.org,
santosh.shukla@amd.com
Subject: Re: [RFC v2] perf: Rewrite core context handling
Date: Thu, 25 Aug 2022 11:17:29 +0200 [thread overview]
Message-ID: <Ywc+Kc7p9svJ79ml@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <10d8889e-4ca9-7e4e-a3e4-d769da79d047@amd.com>
On Thu, Aug 25, 2022 at 11:09:05AM +0530, Ravi Bangoria wrote:
> > -static inline int __pmu_filter_match(struct perf_event *event)
> > -{
> > - struct pmu *pmu = event->pmu;
> > - return pmu->filter_match ? pmu->filter_match(event) : 1;
> > -}
> > -
> > -/*
> > - * Check whether we should attempt to schedule an event group based on
> > - * PMU-specific filtering. An event group can consist of HW and SW events,
> > - * potentially with a SW leader, so we must check all the filters, to
> > - * determine whether a group is schedulable:
> > - */
> > -static inline int pmu_filter_match(struct perf_event *event)
> > -{
> > - struct perf_event *sibling;
> > -
> > - if (!__pmu_filter_match(event))
> > - return 0;
> > -
> > - for_each_sibling_event(sibling, event) {
> > - if (!__pmu_filter_match(sibling))
> > - return 0;
> > - }
> > -
> > - return 1;
> > -}
> > -
> > static inline int
> > event_filter_match(struct perf_event *event)
> > {
> > return (event->cpu == -1 || event->cpu == smp_processor_id()) &&
> > - perf_cgroup_match(event) && pmu_filter_match(event);
> > + perf_cgroup_match(event);
>
> There are many callers of event_filter_match() which might not endup calling
> visit_groups_merge(). I hope this is intentional change?
I thought I did, but lets go through them again.
event_filter_match() is called from:
- __perf_event_enable(); here we'll end up in ctx_sched_in() which
will dutifully skip the pmu in question.
(fwiw, this is one of those sites where ctx_sched_{out,in}() could do
with a @pmu argument.
- merge_sched_in(); this is after the new callsite in
visit_groups_merge().
- perf_adjust_freq_unthrottle_context(); if the pmu was skipped in
visit_groups_merge() then ->state != ACTIVE and we'll bail out.
- perf_iterate_ctx() / perf_iterate_sb_cpu(); these are for generating
side-band events, and arguably not delivering them when running on
the 'wrong' CPU wasn't right to begin with.
So I tihnk we're good. Hmm?
next prev parent reply other threads:[~2022-08-25 9:18 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 13:47 [RFC v2] perf: Rewrite core context handling Ravi Bangoria
2022-01-17 7:18 ` [perf] f7cf7134e4: WARNING:at_kernel/events/core.c:#__pmu_ctx_sched_out kernel test robot
2022-01-31 4:43 ` [RFC v2] perf: Rewrite core context handling Ravi Bangoria
2022-06-13 14:35 ` Peter Zijlstra
2022-06-13 14:36 ` Peter Zijlstra
2022-06-13 14:38 ` Peter Zijlstra
2022-08-02 6:11 ` Ravi Bangoria
2022-08-22 15:29 ` Peter Zijlstra
2022-08-22 15:43 ` Peter Zijlstra
2022-08-22 16:37 ` Ravi Bangoria
2022-08-23 4:20 ` Ravi Bangoria
2022-08-29 3:54 ` Ravi Bangoria
2022-08-23 6:30 ` Peter Zijlstra
2022-08-29 4:00 ` Ravi Bangoria
2022-08-29 11:58 ` Peter Zijlstra
2022-08-22 16:52 ` Peter Zijlstra
2022-08-23 4:57 ` Ravi Bangoria
2022-06-13 14:41 ` Peter Zijlstra
2022-08-22 14:38 ` Ravi Bangoria
2022-06-13 14:43 ` Peter Zijlstra
2022-08-02 6:16 ` Ravi Bangoria
2022-08-23 8:57 ` Peter Zijlstra
2022-08-24 5:07 ` Ravi Bangoria
2022-08-24 7:27 ` Peter Zijlstra
2022-08-24 7:53 ` Ravi Bangoria
2022-06-13 14:55 ` Peter Zijlstra
2022-08-02 6:10 ` Ravi Bangoria
2022-08-22 16:44 ` Peter Zijlstra
2022-08-23 4:46 ` Ravi Bangoria
2022-06-17 13:36 ` Peter Zijlstra
2022-08-24 10:13 ` Peter Zijlstra
2022-06-27 4:18 ` Ravi Bangoria
2022-08-02 6:06 ` Ravi Bangoria
2022-08-24 12:15 ` Peter Zijlstra
2022-08-24 14:59 ` Peter Zijlstra
2022-08-25 5:39 ` Ravi Bangoria
2022-08-25 9:17 ` Peter Zijlstra [this message]
2022-08-25 11:03 ` Ravi Bangoria
2022-08-02 6:13 ` Ravi Bangoria
2022-08-23 7:10 ` Peter Zijlstra
2022-08-02 6:17 ` Ravi Bangoria
2022-08-23 7:26 ` Peter Zijlstra
2022-08-23 15:14 ` Ravi Bangoria
2022-08-22 14:40 ` Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ywc+Kc7p9svJ79ml@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=eranian@google.com \
--cc=frederic@kernel.org \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=kim.phillips@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mark.rutland@arm.com \
--cc=megha.dey@intel.com \
--cc=namhyung@kernel.org \
--cc=ravi.bangoria@amd.com \
--cc=santosh.shukla@amd.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).