From: Johan Hovold <johan@kernel.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Johan Hovold <johan+linaro@kernel.org>,
linux-clk@vger.kernel.org,
Krishna Kurapati <quic_kriskura@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH v2 2/2] clk: qcom: gcc-sc7280: Keep the USB GDSCs always on
Date: Fri, 26 Aug 2022 09:16:38 +0200 [thread overview]
Message-ID: <YwhzVlTZLMCAbZi7@hovoldconsulting.com> (raw)
In-Reply-To: <20220825182152.v2.2.If09027f73daa6e1ed95f5eab02326b543c67132e@changeid>
On Thu, Aug 25, 2022 at 06:21:59PM -0700, Matthias Kaehlcke wrote:
> When the GDSC is disabled during system suspend USB is broken on
> sc7280 when the system resumes. Mark the GDSC as always on to
> make sure USB still works after system suspend.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
>
> Changes in v2:
> - set the flags of the GDSC not of the GDSC power domain
> - updated commit message
>
> drivers/clk/qcom/gcc-sc7280.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/gcc-sc7280.c b/drivers/clk/qcom/gcc-sc7280.c
> index 7ff64d4d5920..adef68d2cb0b 100644
> --- a/drivers/clk/qcom/gcc-sc7280.c
> +++ b/drivers/clk/qcom/gcc-sc7280.c
Perhaps you can add a comment here about why this is needed similar to
what I did for sc8280xp:
https://lore.kernel.org/all/20220805121250.10347-3-johan+linaro@kernel.org/
> @@ -3127,7 +3127,7 @@ static struct gdsc gcc_usb30_prim_gdsc = {
> .name = "gcc_usb30_prim_gdsc",
> },
> .pwrsts = PWRSTS_OFF_ON,
> - .flags = VOTABLE,
> + .flags = VOTABLE | ALWAYS_ON,
> };
>
> static struct gdsc gcc_usb30_sec_gdsc = {
Look good otherwise. For both patches:
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Johan
next prev parent reply other threads:[~2022-08-26 7:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 1:21 [PATCH v2 1/2] clk: qcom: gcc-sc7180: Keep the USB GDSC always on Matthias Kaehlcke
2022-08-26 1:21 ` [PATCH v2 2/2] clk: qcom: gcc-sc7280: Keep the USB GDSCs " Matthias Kaehlcke
2022-08-26 7:16 ` Johan Hovold [this message]
2022-08-26 15:12 ` Matthias Kaehlcke
2022-08-26 2:40 ` [PATCH v2 1/2] clk: qcom: gcc-sc7180: Keep the USB GDSC " Bjorn Andersson
2022-08-29 8:12 ` Rajendra Nayak
2022-08-30 18:43 ` Matthias Kaehlcke
2022-08-30 21:35 ` Stephen Boyd
2022-09-01 5:46 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwhzVlTZLMCAbZi7@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=mturquette@baylibre.com \
--cc=quic_kriskura@quicinc.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).