From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EAC5ECAAD2 for ; Mon, 29 Aug 2022 09:34:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229917AbiH2Jd7 (ORCPT ); Mon, 29 Aug 2022 05:33:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229679AbiH2Jdz (ORCPT ); Mon, 29 Aug 2022 05:33:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 407775C94C; Mon, 29 Aug 2022 02:33:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BC37B60FC6; Mon, 29 Aug 2022 09:33:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9350BC433C1; Mon, 29 Aug 2022 09:33:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1661765632; bh=lT0Gv6sCfp7Xa8kCHxUOI7Yq9QfRd2TNlO/WqA0gGLk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OUKJCmW4/I+GLUy1XFmCpQh8lII1juX35mwZ+5ttPVDgD70Ie4Xo6rUYqpGZhZvHh orS7Bnm+NSLdNJMPN2Onn2EEhvdScPiWgVwlI1RlR8TbGIQCl67TtA+TgjUMqdyQ2u nt2fGjIl0Lvob4E7wvH6UIfupSM4E1bWQmI0cgtc= Date: Mon, 29 Aug 2022 11:33:48 +0200 From: Greg Kroah-Hartman To: Jiri Slaby Cc: Ondrej Mosnacek , Linux kernel mailing list , Linux Stable maillist , Masahiro Yamada Subject: Re: [PATCH 5.19 145/365] kbuild: dummy-tools: avoid tmpdir leak in dummy gcc Message-ID: References: <20220823080118.128342613@linuxfoundation.org> <20220823080124.294570326@linuxfoundation.org> <9996285f-5a50-e56a-eb1c-645598381a20@kernel.org> <71dbe196-a3d4-41f4-a00c-24f8b0222288@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 29, 2022 at 10:05:13AM +0200, Greg Kroah-Hartman wrote: > On Mon, Aug 29, 2022 at 09:12:39AM +0200, Jiri Slaby wrote: > > On 27. 08. 22, 10:34, Ondrej Mosnacek wrote: > > > On Sat, Aug 27, 2022 at 9:51 AM Jiri Slaby wrote: > > > > On 23. 08. 22, 10:00, Greg Kroah-Hartman wrote: > > > > > From: Ondrej Mosnacek > > > > > > > > > > commit aac289653fa5adf9e9985e4912c1d24a3e8cbab2 upstream. > > > > > > > > > > When passed -print-file-name=plugin, the dummy gcc script creates a > > > > > temporary directory that is never cleaned up. To avoid cluttering > > > > > $TMPDIR, instead use a static directory included in the source tree. > > > > > > > > This breaks our (SUSE) use of dummy tools (GCC_PLUGINS became =n). I > > > > will investigate whether this is stable-only and the root cause later. > > > > > > It looks like both the Greg's generated patch and the final stable > > > commit (d7e676b7dc6a) are missing the addition of the empty > > > plugin-version.h file. It appears in the patch's diffstat, but not in > > > the actual diff. The mainline commit does include the empty file > > > correctly, so it's likely a bug in the stable cherry pick automation. > > > > Right, this fixed the issue for me: > > --- a/patches.kernel.org/5.19.4-144-kbuild-dummy-tools-avoid-tmpdir-leak-in-dummy-.patch > > +++ b/patches.kernel.org/5.19.4-144-kbuild-dummy-tools-avoid-tmpdir-leak-in-dummy-.patch > > @@ -20,6 +20,8 @@ Signed-off-by: Jiri Slaby > > scripts/dummy-tools/gcc | 8 ++------ > > 1 file changed, 2 insertions(+), 6 deletions(-) > > > > +diff --git a/scripts/dummy-tools/dummy-plugin-dir/include/plugin-version.h > > b/scripts/dummy-tools/dummy-plugin-dir/include/plugin-version.h > > +new file mode 100644 > > diff --git a/scripts/dummy-tools/gcc b/scripts/dummy-tools/gcc > > index b2483149bbe5..7db825843435 100755 > > --- a/scripts/dummy-tools/gcc > > Ick, looks like a bad interaction between git and quilt, and then back > to git. I'll manually fix this up and push out a new stable release > with it. Odd, 5.15.y worked just fine, but 5.10.y and 5.19.y did not. I've done a new 5.10 and 5.19 release with this fixed up. If there are still any issues here, please let me know. thanks, greg k-h