From: Leon Romanovsky <leon@kernel.org>
To: Jinpu Wang <jinpu.wang@ionos.com>
Cc: jgg@ziepe.ca, linux-rdma@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] RDMA: dma-mapping: Return an unsigned int from ib_dma_map_sg{,_attrs}
Date: Mon, 29 Aug 2022 15:06:43 +0300 [thread overview]
Message-ID: <Ywyr0+b350SZrznw@unreal> (raw)
In-Reply-To: <CAMGffEmffkW0fHrjx84gQ6FnWuwriRUg=HSdwzU4W_sZLdiT7g@mail.gmail.com>
On Mon, Aug 29, 2022 at 11:40:40AM +0200, Jinpu Wang wrote:
> On Sun, Aug 28, 2022 at 1:09 PM Leon Romanovsky <leon@kernel.org> wrote:
> >
> > On Fri, Aug 26, 2022 at 11:56:15AM +0200, Jack Wang wrote:
> > > Following 2a047e0662ae ("dma-mapping: return an unsigned int from dma_map_sg{,_attrs}")
> > > change the return value of ib_dma_map_sg{,attrs} to unsigned int.
> > >
> > > Cc: Jason Gunthorpe <jgg@ziepe.ca>
> > > Cc: Leon Romanovsky <leon@kernel.org>
> > > Cc: Christoph Hellwig <hch@lst.de>
> > > Cc: linux-rdma@vger.kernel.org
> > > Cc: linux-kernel@vger.kernel.org
> > >
> > > Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
> > > ---
> > > drivers/infiniband/core/device.c | 2 +-
> > > include/rdma/ib_verbs.h | 6 +++---
> > > 2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > You forgot to change ib_dma_map_sgtable_attrs() and various
> > ib_dma_map_sg*() callers.
> No, they are different.
> ib_dma_map_sgtable_attrs and dma_map_sgtable return negative on errors.
It is not the point. You changed ib_dma_virt_map_sg() to be unsigned,
so now the following lines are not correct:
4138 int nents;
4139
4140 if (ib_uses_virt_dma(dev)) {
4141 nents = ib_dma_virt_map_sg(dev, sgt->sgl, sgt->orig_nents);
"int nents" should be changed to "unsigned int".
Thanks
> >
> > Thanks
> Thanks!
next prev parent reply other threads:[~2022-08-29 12:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220826095615.74328-1-jinpu.wang@ionos.com>
2022-08-26 9:56 ` [PATCH 1/2] infiniband/mthca: Fix dma_map_sg error check Jack Wang
2022-08-28 10:10 ` Leon Romanovsky
2022-08-29 5:27 ` Jinpu Wang
2022-08-26 9:56 ` [PATCH 2/2] RDMA: dma-mapping: Return an unsigned int from ib_dma_map_sg{,_attrs} Jack Wang
2022-08-28 11:09 ` Leon Romanovsky
2022-08-29 9:40 ` Jinpu Wang
2022-08-29 12:06 ` Leon Romanovsky [this message]
2022-08-29 13:19 ` Jinpu Wang
2022-08-30 8:01 ` Leon Romanovsky
2022-08-30 8:23 ` Jinpu Wang
2022-08-30 9:13 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ywyr0+b350SZrznw@unreal \
--to=leon@kernel.org \
--cc=hch@lst.de \
--cc=jgg@ziepe.ca \
--cc=jinpu.wang@ionos.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).