From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76A8DECAAD3 for ; Tue, 6 Sep 2022 00:23:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232540AbiIFAXr (ORCPT ); Mon, 5 Sep 2022 20:23:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229575AbiIFAXo (ORCPT ); Mon, 5 Sep 2022 20:23:44 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A41226555E; Mon, 5 Sep 2022 17:23:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=d9OXgRNebu5UPVkhM/ybQh6k0eihy+EGudxgU/QSYdI=; b=LaY2GSFeaQvgTZ/4J74fhAgY23 krIGialM91/ySLoO1qK0qWDfDzlsY7PcVXmFvDXFiY2ZEvRtb2f1ZIrjwRO/ySkqdNsQNrhi29efN dEaJi6stegK0+Xcaa3kkU1f+C0KfqyIrcNipRMXfv3Gx+AfufaKCibiF9Rvuw1FP6rek=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oVMMc-00FhWk-LL; Tue, 06 Sep 2022 02:22:50 +0200 Date: Tue, 6 Sep 2022 02:22:50 +0200 From: Andrew Lunn To: rentao.bupt@gmail.com Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Heyi Guo , Dylan Hung , Guangbin Huang , Liang He , Hao Chen , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Tao Ren , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/2] ARM: dts: aspeed: elbert: Enable mac3 controller Message-ID: References: <20220905235634.20957-1-rentao.bupt@gmail.com> <20220905235634.20957-3-rentao.bupt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220905235634.20957-3-rentao.bupt@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 05, 2022 at 04:56:34PM -0700, rentao.bupt@gmail.com wrote: > From: Tao Ren > > Enable mac3 controller in Elbert dts: Elbert MAC3 is connected to the > onboard switch directly (fixed link). What is the switch? Could you also add a DT node for it? > > Signed-off-by: Tao Ren > --- > arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dts > index 27b43fe099f1..52cb617783ac 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dts > @@ -183,3 +183,14 @@ imux31: i2c@7 { > &i2c11 { > status = "okay"; > }; > + > +&mac3 { > + status = "okay"; > + phy-mode = "rgmii"; 'rgmii' is suspicious, though not necessarily wrong. This value is normally passed to the PHY, so the PHY inserts the RGMII delay. You however don't have a PHY. So i assume the switch is inserting the delay? Again, being able to see the DT properties for the switch would be useful. Andrew