From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9251BECAAA1 for ; Tue, 6 Sep 2022 04:53:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232406AbiIFExr (ORCPT ); Tue, 6 Sep 2022 00:53:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232211AbiIFExp (ORCPT ); Tue, 6 Sep 2022 00:53:45 -0400 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F25472A257; Mon, 5 Sep 2022 21:53:41 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1oVQaN-001Phz-S2; Tue, 06 Sep 2022 14:53:20 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Tue, 06 Sep 2022 12:53:19 +0800 Date: Tue, 6 Sep 2022 12:53:19 +0800 From: Herbert Xu To: Neal Liu Cc: "David S . Miller" , Joel Stanley , Andrew Jeffery , linux-aspeed@lists.ozlabs.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, BMC-SW@aspeedtech.com, kernel test robot , Sudip Mukherjee Subject: Re: [PATCH v2] crypto: aspeed: fix build module error Message-ID: References: <20220905025433.1610696-1-neal_liu@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220905025433.1610696-1-neal_liu@aspeedtech.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 05, 2022 at 10:54:33AM +0800, Neal Liu wrote: > If CONFIG_MODULES=y and CONFIG_CRYPTO_DEV_ASPEED=m, > build modpost would be failed. > > Error messages: > ERROR: modpost: "aspeed_register_hace_hash_algs" > [drivers/crypto/aspeed/aspeed_crypto.ko] undefined! > ERROR: modpost: "aspeed_unregister_hace_hash_algs" > [drivers/crypto/aspeed/aspeed_crypto.ko] undefined! > > Change build sequence to fix this. > > Reported-by: kernel test robot > Signed-off-by: Neal Liu > Tested-by: Sudip Mukherjee > --- > v2: Remove redundant obj- lines. > > drivers/crypto/aspeed/Makefile | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt